From owner-svn-src-all@freebsd.org Tue Jul 28 15:14:23 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1DAD336C8CB; Tue, 28 Jul 2020 15:14:23 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BGKvy23d5z4WFk; Tue, 28 Jul 2020 15:14:22 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd2a.google.com with SMTP id a5so5869878ioa.13; Tue, 28 Jul 2020 08:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nKFgKvHVY7BJjktMQ97WwxfuyPRo92GSzSsByqlBtk4=; b=XtE5WWtHN5sUBFJu3bdxKQdhNdLGNKp+WdRT3hKTN2q2eBuga7034yxIdQu6+gZHaz Z2VHA6PuEELC6weDXINuO4TQAJkT0nUwLpo+oP2JR7EGagTXizlbK/Zws+GM0vBp/Gvz ZQ/vfDi5xrZKUFAr2KtFOl3E2Spfbeks2Tw053XO+YRotOBdYUxS65YUb3fYXNfhtm3G OOUhlejuNosAghwxDfSKHKHMQjO1GF9Ojovt9EKLG7YbSHQxOAPtHLLo9B+zxQS+Q639 52begwXa1ge8UUNV6oQn8zLRPtvjAu4qyT4ZAao/ULjw5ueEUZEt4Ewl+v59ivRQKU1C 6yYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=nKFgKvHVY7BJjktMQ97WwxfuyPRo92GSzSsByqlBtk4=; b=Gu05Jbo/TED2/lf2Sgn5NdgMKtLmLPm1gfgIW6LBmh/hREbdNCQ+mKpqbghEH3wE5k kGXKHs1W4hmmUMCGdRu1D82mgwlUeuF1vPHt2KpD+L94/y5GfjG/BoCaTLryfeR42qUp kcbXmcl3it568XV8wYrHv4oZRxBeQ+Ii6S7kAUDdgb91V4itDc+1l8ENLZD/MVlD7nY5 jQkMsYnP8GBq99Ko0WXoH61OvNVcs/scKdVU62bdTjkkZV2qlcBQjQ+NiRA9sOBi4hyr 2ZvA1HDiLo9DgehE3eeKL7T6DLPhD8+voW+GgK3OSufbBAV/yEYdm0+5wBYqtvP6GyA6 oNkw== X-Gm-Message-State: AOAM5306FE2cgcjgxzpXiZ3/mpA8XnRye/4147LXGeDWmhklhVFZSnX4 qJH8Fu9MxHeSCkK85SyAXxgQqhXJ+Tw= X-Google-Smtp-Source: ABdhPJyBHCNKxkgIxguZy3Vg+3nVUi2VkR7n8Sg0cObqY9xll6zLpT5gGxMOzXgHARUUjxnwklWpZQ== X-Received: by 2002:a05:6638:138a:: with SMTP id w10mr17004926jad.36.1595949261077; Tue, 28 Jul 2020 08:14:21 -0700 (PDT) Received: from raichu (toroon0560w-lp130-08-67-71-176-35.dsl.bell.ca. [67.71.176.35]) by smtp.gmail.com with ESMTPSA id x88sm3404761ilk.81.2020.07.28.08.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2020 08:14:20 -0700 (PDT) Sender: Mark Johnston Date: Tue, 28 Jul 2020 11:14:18 -0400 From: Mark Johnston To: Eric van Gyzen Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r363607 - head/sys/vm Message-ID: <20200728151418.GE59953@raichu> References: <202007271425.06REPBtv075771@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4BGKvy23d5z4WFk X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=XtE5WWtH; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::d2a as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-1.94 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-0.98)[-0.976]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; NEURAL_HAM_LONG(-1.02)[-1.024]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.24)[-0.240]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::d2a:from]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2020 15:14:23 -0000 On Tue, Jul 28, 2020 at 08:44:11AM -0500, Eric van Gyzen wrote: > On 7/27/20 9:25 AM, Mark Johnston wrote: > > + > > + /* > > + * We may be attempting to free the page as part of the handling for an > > + * I/O error, in which case the page was xbusied by a different thread. > > + */ > > + vm_page_xbusy_claim(m); > > I've just noticed that vm_page_xbusy_claim() ignores the WAITERS bit. > Is this not a problem in practice? Thanks, I think you're right. I posted a proposed patch here: https://reviews.freebsd.org/D25859