From owner-p4-projects@FreeBSD.ORG  Sat Aug 18 20:27:49 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1CCEB16A421; Sat, 18 Aug 2007 20:27:49 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CF0AC16A418
	for <perforce@FreeBSD.org>; Sat, 18 Aug 2007 20:27:48 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id BF53D13C468
	for <perforce@FreeBSD.org>; Sat, 18 Aug 2007 20:27:48 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7IKRmje074383
	for <perforce@FreeBSD.org>; Sat, 18 Aug 2007 20:27:48 GMT
	(envelope-from cnst@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7IKRmdX074380
	for perforce@freebsd.org; Sat, 18 Aug 2007 20:27:48 GMT
	(envelope-from cnst@FreeBSD.org)
Date: Sat, 18 Aug 2007 20:27:48 GMT
Message-Id: <200708182027.l7IKRmdX074380@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	cnst@FreeBSD.org using -f
From: "Constantine A. Murenin" <cnst@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 125323 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Aug 2007 20:27:49 -0000

http://perforce.freebsd.org/chv.cgi?CH=125323

Change 125323 by cnst@dale on 2007/08/18 20:27:10

	declaring sc_dev as a member of softc and leaving it completely
	uninitialised is dangerous; in fact, it caused me a few page-traps
	and reboots when I was converting it to my framework

Affected files ...

.. //depot/projects/soc2007/cnst-sensors/sys.dev.coretemp/coretemp.c#2 edit

Differences ...

==== //depot/projects/soc2007/cnst-sensors/sys.dev.coretemp/coretemp.c#2 (text+ko) ====

@@ -136,6 +136,8 @@
 	int cpu_model;
 	int cpu_mask;
 
+	sc->sc_dev = dev;
+
 	pdev = device_get_parent(dev);
 
 	cpu_model  = (cpu_id >> 4) & 15;