From owner-freebsd-current Mon Dec 27 16:44:37 1999 Delivered-To: freebsd-current@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id 5AAC514CE8 for ; Mon, 27 Dec 1999 16:44:25 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.2) with ESMTP id BAA08504; Tue, 28 Dec 1999 01:44:15 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Matthew Dillon Cc: freebsd-current@FreeBSD.ORG Subject: Re: Proposed patch to fix VN device (again) In-reply-to: Your message of "Mon, 27 Dec 1999 16:26:59 PST." <199912280026.QAA34572@apollo.backplane.com> Date: Tue, 28 Dec 1999 01:44:15 +0100 Message-ID: <8502.946341855@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <199912280026.QAA34572@apollo.backplane.com>, Matthew Dillon writes: > VN calls vm_pager_strategy() which collects I/O in filesystem buffers > (bp)'s in order to cluster the I/O, and you cannot initiate I/O on > filesystem buffers without a valid b_dev. > > So, the jist of the problem is that in order to get reasonable performance > out of the thing (i.e. not issue 4K I/O's to the disk), we have to use > filesystem buffers which means the bp must be properly initialized. vm_pager_strategy() branches out based on the object type and ends up in swap_pager_strategy() which only uses b_dev after calling swstrategy() then only in a diagnostic printf which we had better never reach. swstrategy() which initializes bp->b_dev to the right physical device. I'm afraid I don't see why or where we would need the bogus /dev/drum dev_t. Furthermore, since we have already clustered above the VN device, I seriously doubt the utility of doing it again between VN and the swapdevice. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message