Date: Sun, 15 Nov 2015 07:27:18 -0700 From: Ian Lepore <ian@freebsd.org> To: Garrett Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290840 - head/etc Message-ID: <1447597638.1254.16.camel@freebsd.org> In-Reply-To: <201511150304.tAF34dD2062713@repo.freebsd.org> References: <201511150304.tAF34dD2062713@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2015-11-15 at 03:04 +0000, Garrett Cooper wrote: > Author: ngie > Date: Sun Nov 15 03:04:39 2015 > New Revision: 290840 > URL: https://svnweb.freebsd.org/changeset/base/290840 > > Log: > Setup the symlink to /sys to mirror one's current source, e.g. if > my source > tree was /usr/src/svn, /sys would point to usr/src/svn > > This fixes the assumption that the source tree will always exist at > ${DESTDIR}/usr/src > > MFC after: 1 week > PR: 76362 > Reported by: Scot Hetzel <swhetzel@gmail.com> > Sponsored by: EMC / Isilon Storage Division > > Modified: > head/etc/Makefile > > Modified: head/etc/Makefile > ===================================================================== > ========= > --- head/etc/Makefile Sun Nov 15 01:50:17 2015 (r290839 > ) > +++ head/etc/Makefile Sun Nov 15 03:04:39 2015 (r290840 > ) > @@ -408,7 +408,7 @@ distrib-dirs: ${MTREES:N/*} distrib-clea > ${METALOG.add} ; \ > done; true > .endif > - ${INSTALL_SYMLINK} usr/src/sys ${DESTDIR}/sys > + ${INSTALL_SYMLINK} ${SRCTOP:C/^\///}/sys ${DESTDIR}/sys > .if ${MK_MAN} != "no" > cd ${DESTDIR}${SHAREDIR}/man; \ > for mandir in man*; do \ > This might make some sense if DESTDIR is empty or /, but with most uses of non-empty DESTDIR this is just going to make a symlink to some random place that likely won't even exist on the running system. If source code is later installed to that DESTDIR as well, the /sys link will just be broken in a way that's likely to lead to very confusing errors. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1447597638.1254.16.camel>