From owner-svn-src-head@FreeBSD.ORG Sat Jun 16 11:27:40 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B9DA8106564A; Sat, 16 Jun 2012 11:27:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 34CC28FC0A; Sat, 16 Jun 2012 11:27:40 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q5GBRWrP065995; Sat, 16 Jun 2012 14:27:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q5GBRWWF024730; Sat, 16 Jun 2012 14:27:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q5GBRWYq024729; Sat, 16 Jun 2012 14:27:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 16 Jun 2012 14:27:32 +0300 From: Konstantin Belousov To: Tijl Coosemans Message-ID: <20120616112732.GN2337@deviant.kiev.zoral.com.ua> References: <201206122137.q5CLbReK077123@svn.freebsd.org> <4FDC54C0.3030105@coosemans.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Zz8eIV9MTSc31S3o" Content-Disposition: inline In-Reply-To: <4FDC54C0.3030105@coosemans.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r236976 - head/sbin/fsck_ffs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 11:27:40 -0000 --Zz8eIV9MTSc31S3o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 16, 2012 at 11:41:20AM +0200, Tijl Coosemans wrote: > On 12-06-2012 23:37, Konstantin Belousov wrote: > > Author: kib > > Date: Tue Jun 12 21:37:27 2012 > > New Revision: 236976 > > URL: http://svn.freebsd.org/changeset/base/236976 > >=20 > > Log: > > For incompleted block allocations or frees, the inode block count usa= ge > > must be recalculated. The blk_check pass of suj checker explicitely m= arks > > inodes which owned such blocks as needing block count adjustment. But > > ino_adjblks() is only called by cg_trunc pass, which is performed bef= ore > > blk_check. As result, the block use count for such inodes is left wro= ng. > > This causes full fsck run after journaled run to still find inconsist= encies > > like 'INCORRECT BLOCK COUNT I=3D14557 (328 should be 0)' in phase 1. > > =20 > > Fix this issue by running additional adj_blk pass after blk_check, wh= ich > > updates the field. > > =20 > > Reviewed by: jeff, mckusick > > MFC after: 1 week >=20 > Thanks! This probably fixes http://www.freebsd.org/cgi/query-pr.cgi?pr=3D= 165950 There is more in the PR then just 'INCORRECT BLOCK COUNT' inconsistency. Somebody will look at the remaining issues eventually. --Zz8eIV9MTSc31S3o Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk/cbaMACgkQC3+MBN1Mb4gY5gCfZsCq3bC+6Whj8T22ONc//89n k5EAoKFC8vXs8EB3q+rttRvjduX2ltHM =Nkbl -----END PGP SIGNATURE----- --Zz8eIV9MTSc31S3o--