Date: Sat, 16 Jun 2012 14:27:32 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Tijl Coosemans <tijl@coosemans.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r236976 - head/sbin/fsck_ffs Message-ID: <20120616112732.GN2337@deviant.kiev.zoral.com.ua> In-Reply-To: <4FDC54C0.3030105@coosemans.org> References: <201206122137.q5CLbReK077123@svn.freebsd.org> <4FDC54C0.3030105@coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Zz8eIV9MTSc31S3o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 16, 2012 at 11:41:20AM +0200, Tijl Coosemans wrote: > On 12-06-2012 23:37, Konstantin Belousov wrote: > > Author: kib > > Date: Tue Jun 12 21:37:27 2012 > > New Revision: 236976 > > URL: http://svn.freebsd.org/changeset/base/236976 > >=20 > > Log: > > For incompleted block allocations or frees, the inode block count usa= ge > > must be recalculated. The blk_check pass of suj checker explicitely m= arks > > inodes which owned such blocks as needing block count adjustment. But > > ino_adjblks() is only called by cg_trunc pass, which is performed bef= ore > > blk_check. As result, the block use count for such inodes is left wro= ng. > > This causes full fsck run after journaled run to still find inconsist= encies > > like 'INCORRECT BLOCK COUNT I=3D14557 (328 should be 0)' in phase 1. > > =20 > > Fix this issue by running additional adj_blk pass after blk_check, wh= ich > > updates the field. > > =20 > > Reviewed by: jeff, mckusick > > MFC after: 1 week >=20 > Thanks! This probably fixes http://www.freebsd.org/cgi/query-pr.cgi?pr=3D= 165950 There is more in the PR then just 'INCORRECT BLOCK COUNT' inconsistency. Somebody will look at the remaining issues eventually. --Zz8eIV9MTSc31S3o Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk/cbaMACgkQC3+MBN1Mb4gY5gCfZsCq3bC+6Whj8T22ONc//89n k5EAoKFC8vXs8EB3q+rttRvjduX2ltHM =Nkbl -----END PGP SIGNATURE----- --Zz8eIV9MTSc31S3o--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120616112732.GN2337>