From owner-freebsd-arch  Fri Mar  9  0: 0:58 2001
Delivered-To: freebsd-arch@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP id 042D737B719
	for <arch@FreeBSD.ORG>; Fri,  9 Mar 2001 00:00:55 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id TAA25284;
	Fri, 9 Mar 2001 19:00:36 +1100
Date: Fri, 9 Mar 2001 19:00:09 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Warner Losh <imp@village.org>
Cc: Kris Kennaway <kris@obsecurity.org>,
	"Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>,
	"Matthew D. Fuller" <fullermd@futuresouth.com>, arch@FreeBSD.ORG
Subject: Re: Breaking up make.conf 
In-Reply-To: <200103090430.f294Ucs04824@billy-club.village.org>
Message-ID: <Pine.BSF.4.21.0103091847030.484-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Thu, 8 Mar 2001, Warner Losh wrote:

> In message <20010308201422.A94052@mollari.cthul.hu> Kris Kennaway writes:
> : All that searching sounds like it would slow things down given the
> : number of times make runs during a make world.  On the other hand,
> : recursively including parent Makefile.incs until there are no more
> : parents, and then pulling in a config file also adds more work.
> 
> I think it would be a wash.  Also, recursively including the parents
> is going to need this same sort of searching because you can't just
> include ${.CURDIR}/../Makefile.inc, since ${.CURDIR} isn't where
> Makefile.inc lives, but where Makefile lives (trust me on this, I've
> tried it before and it blows up).  We have makefiles at too many

For this reason, many includes of ${..CURDIR}/../Makefile.inc are style
bugs at best.  Use `.include "../Makefile.inc"' to prefer including
relative to the directory containing the file doing the including.  (I
think there is an undocumented search path involving that directory,
${.CURDIR} and ${.OBJDIR} even for this.  It can be hard to tell which
file will be included.  E.g., suppose you have a stale .depend in
${.CURDIR} and no .depend in ${.OBJDIR}.  Then the stale .depend gets
used.)

Anyway, make(1) often does lengthy directory searches to find files.
I don't know if these are more efficient than explicitly coded searches.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message