From owner-freebsd-net@freebsd.org Thu Dec 17 21:53:09 2015 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71D78A4BCA8 for ; Thu, 17 Dec 2015 21:53:09 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.rbsd.freebsd.org (unknown [IPv6:2607:fc50:2000:101::1bb:73]) by mx1.freebsd.org (Postfix) with ESMTP id 5E3F11A41 for ; Thu, 17 Dec 2015 21:53:09 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.rbsd.freebsd.org (Postfix, from userid 1346) id 5B9C311302; Thu, 17 Dec 2015 21:53:09 +0000 (UTC) Date: Thu, 17 Dec 2015 21:53:09 +0000 To: freebsd-net@freebsd.org From: "smh (Steven Hartland)" Reply-to: D1986+325+381818416dc12ca2@reviews.freebsd.org Subject: [Differential] [Commented On] D1986: Teach lagg(4) to change MTU Message-ID: <6be594b095612d5f1d23550ccf3027dc@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D1986: Teach lagg(4) to change MTU X-Herald-Rules: none, <28> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: ODZhMzNlYThiYzMxOTgzYmRhMDE5M2Q2Yzk4IFZzLsU= MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2015 21:53:09 -0000 smh added a subscriber: smh. smh added a comment. Some general style nits and a question re-loss of the mtu set error. INLINE COMMENTS sys/net/if_lagg.c:706 style(9) bool use of pointer type. sys/net/if_lagg.c:731 style(9) four space additional indent only should be used, more below. sys/net/if_lagg.c:769 Looks like this attempts to change more that would have been done above before the error, is that intended? sys/net/if_lagg.c:783 Looks like the error gets lost, although printed, is there no way we can avoid this? sys/net/if_lagg.c:812 style(9) bracing around return. sys/net/if_lagg.c:818 style(9) init of vars in declaration should be avoided. Moving to down to where its first needed can avoid setting it at all. sys/net/if_lagg.c:837 style(9) bool use of pointer type. sys/net/if_lagg.c:843 style(9) bool use of pointer type. sys/net/if_lagg.c:852 consider: "it might have been updated." sys/net/if_lagg.c:861 style(9) bool use of pointer type. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D1986 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rpokala, rstone, rpokala-panasas.com Cc: smh, imp, melifaro, hrs, sbruno, lakshmi.n_msystechnologies.com, emaste, ae, freebsd-net-list