From owner-cvs-all Wed Apr 10 11:28:49 2002 Delivered-To: cvs-all@freebsd.org Received: from espresso.q9media.com (espresso.q9media.com [216.254.138.122]) by hub.freebsd.org (Postfix) with ESMTP id 0371F37B422; Wed, 10 Apr 2002 11:28:22 -0700 (PDT) Received: (from mike@localhost) by espresso.q9media.com (8.11.6/8.11.6) id g3AILaS77291; Wed, 10 Apr 2002 14:21:36 -0400 (EDT) (envelope-from mike) Date: Wed, 10 Apr 2002 14:21:36 -0400 From: Mike Barcroft To: Hajimu UMEMOTO Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet in.h src/sys/netinet6 in6.h Message-ID: <20020410142136.B70911@espresso.q9media.com> References: <200204101159.g3ABx2e55901@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ; from ume@mahoroba.org on Thu, Apr 11, 2002 at 02:15:17AM +0900 Organization: The FreeBSD Project Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hajimu UMEMOTO writes: > Hi, > > >>>>> On Wed, 10 Apr 2002 04:59:02 -0700 (PDT) > >>>>> Mike Barcroft said: > > mike> mike 2002/04/10 04:59:02 PDT > > mike> Modified files: > mike> sys/netinet in.h > mike> sys/netinet6 in6.h > mike> Log: > mike> Unconditionalize the definition of INET_ADDRSTRLEN and > mike> INET6_ADDRSTRLEN. Doing this helps expose bogus redefinitions in 3rd > mike> party software. > > I cannot understand why this change is required. RFC2553 says: It isn't required, it's a matter of correctness. There was no need for them to be conditional in the first place; it was a mistake on my part to make them conditional. > addresses, the buffer must be at least 16-octets. In order to allow > applications to easily declare buffers of the proper size to store > IPv4 and IPv6 addresses in string form, the following two constants > are defined in : > > #define INET_ADDRSTRLEN 16 > #define INET6_ADDRSTRLEN 46 > > I believe this two define shouldn't appear in application side. Right, and if they did it would be considered bogus. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message