From owner-freebsd-current@FreeBSD.ORG Sat Sep 22 23:32:14 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with ESMTP id B3F6116A420; Sat, 22 Sep 2007 23:32:12 +0000 (UTC) (envelope-from mnag@FreeBSD.org) Message-ID: <46F5A5FF.8010906@FreeBSD.org> Date: Sat, 22 Sep 2007 20:32:15 -0300 From: Marcus Alves Grando Organization: FreeBSD.org User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Rong-en Fan References: <46F493FB.6020603@FreeBSD.org> <6eb82e0709212208o6d52c1bdgc4999f7432d4d7d2@mail.gmail.com> In-Reply-To: <6eb82e0709212208o6d52c1bdgc4999f7432d4d7d2@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: freebsd-current@freebsd.org, andre@freebsd.org Subject: Re: sendfile() without struct sf_hdtr broken since rev 1.256 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Sep 2007 23:32:14 -0000 Rong-en Fan wrote: > On 9/22/07, Marcus Alves Grand wrote: >> People, >> >> Since rev 1.256 sendfile broken lighttpd sendfile() that doesn´t use >> struct sf_hdtr. >> >> Sometimes sendfile works sometimes not like you can see below: >> > [...] >> rev 1.256: >> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/kern/uipc_syscalls.c.diff?r1=1.255;r2=1.256 > > Thank you for finding this out. I encountered exactly the same > problem but have no time to investigate. > > BTW, if I downgrade lighttpd to 1.4.16 from 1.4.17/1.4.18, with > rev 1.256 uipc_syscalls.c it works. Ok. I commit one fix for lighttpd. But i still think there´s a problem in sendfile(). For example, if i revert rev 1.256 sendfile return "off_t *sbytes" > 0 otherwise sendfile() return 0 in sbytes many times. Someone know if this new behavior are correct? Regards > > Regards, > Rong-En Fan > >> Regards >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" -- Marcus Alves Grando marcus(at)sbh.eng.br | Personal mnag(at)FreeBSD.org | FreeBSD.org