From owner-svn-src-head@freebsd.org Sun Dec 9 21:03:55 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCA51132FFE5 for ; Sun, 9 Dec 2018 21:03:54 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7933C7C040 for ; Sun, 9 Dec 2018 21:03:53 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-yb1-xb35.google.com with SMTP id b4so1478028ybg.9 for ; Sun, 09 Dec 2018 13:03:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Tbj9gnHHUHwg4olxDPmZQgspWoMcPZpo9ninD2Mm9H0=; b=dgo0wIw017SJNtFpQMPWArroIt5iOD1HUED8uETzgWyZv1GCaAl8EPG+D3LDEJWUKA GoReWco++lnpUmI9D3DEWovx0ApUdIC5Lz/1wbox2PbPI8lPNOTiJNrm/m09iXRXFDfD 3L+xsDwxkax6J+bdUgcaVxQSBqVjmvNmumXKPsJioFukJUufRC4R2uVIfp7K2HIYuDR/ YOxs1k5MaBGDEls0XRDEo0/ZWymRdoeRXzLZ5WaXdfdgezk7N0IsGaHplltagwnOCgCe C3PRUp4A2spkBenIWwVUfDq4X959YdhL6MrPuv5y8gniUewNedxDcYTEihc4yGLLzSgI hV8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Tbj9gnHHUHwg4olxDPmZQgspWoMcPZpo9ninD2Mm9H0=; b=LxTJ1iDnilD1Ne30S4a3eWdPH0XmrWVroN50RUvHe5D4h0MvXyo8e8HeseUdJw3zjj 5Tws5hdI0nLWH+1FZPf5B/YYvwh+stNuKSdlF9BtJS9DNZjeYRArpWrLyRX1YwxEqn2Y yg37722qGkxlN/K8pTfGcbEa50P1/Fuk0joeW25FeEVCOp9FFbiqQXjqwaBBlJZlaMv1 MPANls5Sz9fs+Us/RgxImgEo6AEDEe91UnhF4JJXNdvYMXz6c0EK4JtpPhVdJ7VgLXIf lcfuoD/epDPt0IqPiss3OJNPdNrTVNUA7yjFxgvB9ZACVs+O0GUo19eOFLXTuD18PUXN xOCA== X-Gm-Message-State: AA+aEWbsk9McmZ+DPf13KKNoDDcpqOO46p7KuSiI9R8ld4gCMj5Hl7/F +SRiLTbmKxxmLrrGElz809QIEnmno1ImtyOqesdlDw== X-Google-Smtp-Source: AFSGD/WRtqPIwDJT9SF9I4nPuOWaoYcVwwkkhtNAVaxamXloiH+ij9Z58aOAUMHc2QHmxW1pYVWaSLZg5fEGmqTliAQ= X-Received: by 2002:a25:4983:: with SMTP id w125-v6mr9746796yba.439.1544389432525; Sun, 09 Dec 2018 13:03:52 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a25:84d2:0:0:0:0:0 with HTTP; Sun, 9 Dec 2018 13:03:51 -0800 (PST) In-Reply-To: References: <201812090701.wB9711aN058754@slippy.cwsent.com> <201812091933.wB9JXOvW062964@pdx.rh.CN85.dnsmgr.net> From: Oliver Pinter Date: Sun, 9 Dec 2018 22:03:51 +0100 Message-ID: Subject: Re: svn commit: r341759 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers contrib/wpa/src/eap_c... To: Warner Losh Cc: "Rodney W. Grimes" , "svn-src-head@freebsd.org" , Cy Schubert , "svn-src-all@freebsd.org" , src-committers , Cy Schubert X-Rspamd-Queue-Id: 7933C7C040 X-Spamd-Result: default: False [-2.92 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org]; NEURAL_HAM_MEDIUM(-0.97)[-0.967,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[hardenedbsd.org]; NEURAL_SPAM_SHORT(0.13)[0.130,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; MX_GOOD(-0.01)[alt1.aspmx.l.google.com,aspmx.l.google.com,aspmx2.googlemail.com,alt2.aspmx.l.google.com,aspmx3.googlemail.com]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[5.3.b.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-0.58)[ipnet: 2607:f8b0::/32(-1.49), asn: 15169(-1.30), country: US(-0.09)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Dec 2018 21:03:55 -0000 On Sunday, December 9, 2018, Warner Losh wrote: > On Sun, Dec 9, 2018 at 1:09 PM Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > In message <201812090645.wB96jnso066329@repo.freebsd.org>, Cy Schubert > > > writes: > > > > Author: cy > > > > Date: Sun Dec 9 06:45:49 2018 > > > > New Revision: 341759 > > > > URL: https://svnweb.freebsd.org/changeset/base/341759 > > > > > > > > Log: > > > > MFV r341618: > > > > > > > > Update wpa 2.6 --> 2.7. > > > > > > Relnotes: yes > > > > As an FYI, or maybe a new procedure, doing a reply to > > a commit message adding relnotes: yes does very little > > to insure that this commit gets refered to in release > > notes. > > > > What about we add RELNOTES.missed to the tree > > next to UPDATING, and when someone forgets to tag > > the Relnotes:yes into a commit you just follow up > > with a commit to that file, stating the svn revision > > which was missing the note and then we have a nice > > documented and clean way to extract the missing > > release note items, rather than trying to cull it > > from a thread in a mail list archive. > > > > The file would get truncated to 0 at appropriate > > times on various branches. > > > > How about just RELNOTES. You put the revision that is relevant and a quick > blurb. That way we don't have to look in two places. All release notes go > in here, no exceptions. You can retroactively tag them, or you can commit > this as part of commit. > I don't really know SVN, but there wouldn't be a chicken egg probem during commit time? I mean you would really know the SVN id. So you could only add a specific revision in a different commit to RELEASE file. > > Have a blurb at the top that tells people what > order to add them in, and you'd be set. We'd then retire "relnotes: yes" in > the commit message. This would also allow 'helpers' to format the RELNOTES > file as we go rather than having to play 2 years of catch-up at major > branch times. > > Having it in the commit message just doesn't work, and this is one of many > reasons: Cy forgot. Other times I'll do something and it's only a month > later I realize it needs to be in the release notes after some issue has > come up.... Other times I put relnotes: yes in only to realize that's my > vanity talking, and nobody else cares. > > Warner > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >