From nobody Wed Jun 24 19:20:57 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4glsGz3HYyz6jgdk; Wed, 24 Jun 2026 19:20:59 +0000 (UTC) (envelope-from markj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4glsGz2VFNz3qNx; Wed, 24 Jun 2026 19:20:59 +0000 (UTC) (envelope-from markj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782328859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tlE5VNue/3tNqph0HGdFuUsUSjRcEvCvMHJy4zw3Rdg=; b=fD1xE8ZJ/cJN4I3+DhyXkhDpX6sze07Pbrxwi1eoPOe7Cx3TaYZCttcSTWV3AgwIRqno22 iPrqKw0dsh+MJdDBSOs1F0oVHVXRuAGT6nPs5fcLK/835MtdCk6b47JKYmE8Qjq1iZgwRJ AoABzSy1qkvwMOPFTiHqXLWC0UzxtBlH9DBsllwygc0AJ8/6bEsI+uhJvaU+HPzIPTGzay gK6deeBf0HWj1ClrULojumrRDytD8UVvyvTDJl4Gokd3ufWgzv/cFvj5LWoHw+XM0DM2Bt Y7tc82jW6nbZSR6Hwvksmh+wS/m8J2BgDdrRFyIrL6zsmICQ2ARDoOBcSH5mBQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782328859; a=rsa-sha256; cv=none; b=gOESZTQ+xLeB56Hc7SqEsccOlYQpJYB+B6gHywl88gpVc89YLJrzMj8hDV2fI84FJAEe5V qgs7+k027VJncfwgrTZUPfqRnQ1DxL+W03tiU7mkLvVQdMWkVVvRrE3WigfS9/3gcv1YIr CGGudOcR9ffsER6Ey0sjerQ6mUW+teh9HFgcBLhwPvtm+FlNuSkb6OmzQVnq/eyOop/QiU ido1oJZR68g8Sr4iiWaKoy6Lw/S7zcY9iiZ06R7iVKlAQG+XPtkTIY4uGaEX1GJEJaNUhN 5LL5oSheUvudFT3dT8Xr2Twv3urVNh6Ij4oIUtS7JrSpuzGuW5ddaGLQc655PA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782328859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tlE5VNue/3tNqph0HGdFuUsUSjRcEvCvMHJy4zw3Rdg=; b=leKPW0/GbstjY8B8XzXyHPaVeJvenC6wg+HseqAJ8VgHO6JohnAtJZHVmCFQNJHcNTAuVN Gm0e7Ka1yfF7YCPN9ETY/9w5h6giMrAvVsn2wu/fjfI7FFrk1XzxTsdzYnsHzldZIeZYQm Rs25eWVuWzmu/7lXfxIQZjd7eYyEBOqY+i1GgI2X2BNDeGO4yKyZ9zTDYi39m41vjWz6QO d2/NOjaJDasbNQmLMlbhXYeq1qJ7aJe4SE/5MO1LOVucvM72dsfJwIpFfb3ZS0+X2ztuua 6Jvp9jPEKe8Y6kIADBcQbLiHYdsxjgTi/HxW7mmPgf8kwejBTtupOlKyzKiP7A== Received: from nuc (192-0-220-237.cpe.teksavvy.com [192.0.220.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: markj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4glsGy6VN6zFd4; Wed, 24 Jun 2026 19:20:58 +0000 (UTC) (envelope-from markj@freebsd.org) Date: Wed, 24 Jun 2026 15:20:57 -0400 From: Mark Johnston To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4c4195700249 - main - sys: use curthread_pflags_set/restore to manage TDP_DEADLKTREAT for uio Message-ID: References: <6a3a9b49.1d11c.1396f4fc@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a3a9b49.1d11c.1396f4fc@gitrepo.freebsd.org> On Tue, Jun 23, 2026 at 02:42:17PM +0000, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4c419570024951ad1e477c8d6c3d9968199faf4a > > commit 4c419570024951ad1e477c8d6c3d9968199faf4a > Author: Konstantin Belousov > AuthorDate: 2026-06-21 18:48:06 +0000 > Commit: Konstantin Belousov > CommitDate: 2026-06-23 14:42:03 +0000 > > sys: use curthread_pflags_set/restore to manage TDP_DEADLKTREAT for uio > > For i386, remove now unused label. > Remove unneeded initialization of the 'save' local. > > Reviewed bu: brooks > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Differential revision: https://reviews.freebsd.org/D57726 > [...] > diff --git a/sys/kern/subr_uio.c b/sys/kern/subr_uio.c > index fea1395a7f77..7e492d8aa705 100644 > --- a/sys/kern/subr_uio.c > +++ b/sys/kern/subr_uio.c > @@ -241,7 +241,7 @@ uiomove_faultflag(void *cp, int n, struct uio *uio, int nofault) > size_t cnt; > int error, newflags, save; > > - save = error = 0; > + error = 0; > > KASSERT(uio->uio_rw == UIO_READ || uio->uio_rw == UIO_WRITE, > ("uiomove: mode")); > @@ -264,6 +264,7 @@ uiomove_faultflag(void *cp, int n, struct uio *uio, int nofault) > save = curthread_pflags_set(newflags); > } else { > KASSERT(nofault == 0, ("uiomove: nofault")); > + save = 0; curthread_pflags_restore(0) clears all of curthread->td_pflags. I guess the proper initial value is ~0. > } > > while (n > 0 && uio->uio_resid) { > @@ -291,8 +292,7 @@ uiomove_faultflag(void *cp, int n, struct uio *uio, int nofault) > n -= cnt; > } > out: > - if (save) > - curthread_pflags_restore(save); > + curthread_pflags_restore(save); > return (error); > }