From owner-freebsd-x11@FreeBSD.ORG Sun Apr 15 02:10:51 2007 Return-Path: X-Original-To: x11@freebsd.org Delivered-To: freebsd-x11@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 132F316A400 for ; Sun, 15 Apr 2007 02:10:51 +0000 (UTC) (envelope-from dejan.lesjak@ijs.si) Received: from mail.ijs.si (mail4.ijs.si [193.2.4.66]) by mx1.freebsd.org (Postfix) with ESMTP id B629F13C459 for ; Sun, 15 Apr 2007 02:10:50 +0000 (UTC) (envelope-from dejan.lesjak@ijs.si) Received: from localhost (mail4.ijs.si [193.2.4.66]) by mail.ijs.si (Postfix) with ESMTP id A732C192DC0; Sun, 15 Apr 2007 04:10:49 +0200 (CEST) DKIM-Signature: v=0.5; a=rsa-sha1; c=relaxed/simple; d=ijs.si; s=ja-200610; t=1176603049; bh=TzXQTONwrPqgV2nYTDpvgDi4RT4=; h=DomainKey-Signature: X-Virus-Scanned:Received:Received:Received:Received:From: Organization:To:Subject:Date:User-Agent:Cc:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding: Content-Disposition:Message-Id; b=KctKqj/Z+EhYANGZlSOln95Rf0/agvef Fyg7Va8xCS6KRg1arjjKVtBkNXW3S3TQeSSmetPuzc0/lSxTSDGva2VpNqQhQfX3WwW pAbop53kEEFqusdN8eF2DZGwpid13 DomainKey-Signature: a=rsa-sha1; s=ja-200610; d=ijs.si; c=nofws; q=dns; h=x-virus-scanned:received:from:organization:to:subject:date: user-agent:cc:references:in-reply-to:mime-version:content-type: content-transfer-encoding:content-disposition:message-id; b=j9PfDi7iKc7Tgske19XryV3ldctbwq3+qX1K71TeOLZV4Jqhc4gQZCgxe2m0PdnXH j7sskJ1seONYg7N3XNVOJCbv4kC1JwlkyGgR/6kz47cXwLmjY2agLJdc88iV/DC X-Virus-Scanned: amavisd-new at ijs.si Received: from mail.ijs.si ([193.2.4.66]) by localhost (mail.ijs.si [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3+xeZitZSQgz; Sun, 15 Apr 2007 04:10:48 +0200 (CEST) Received: from edina.ijs.si (edina.ijs.si [193.2.4.3]) by mail.ijs.si (Postfix) with ESMTP id 1A361192DA6; Sun, 15 Apr 2007 04:10:48 +0200 (CEST) Received: from radagast.ijs.si (radagast.ijs.si [193.2.4.168]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by edina.ijs.si (Postfix) with ESMTP id 0E4A5510B6; Sun, 15 Apr 2007 04:10:48 +0200 (CEST) Received: from localhost.ijs.si (localhost.ijs.si [127.0.0.1]) by radagast.ijs.si (8.13.8/8.13.8) with ESMTP id l3F2AlQQ071957; Sun, 15 Apr 2007 04:10:47 +0200 (CEST) (envelope-from dejan.lesjak@ijs.si) From: Dejan Lesjak Organization: IJS To: Kris Kennaway Date: Sun, 15 Apr 2007 04:10:46 +0200 User-Agent: KMail/1.9.6 References: <20070414194028.GB2313@xor.obsecurity.org> <200704142311.47387.dejan.lesjak@ijs.si> <20070415013921.GA68262@xor.obsecurity.org> In-Reply-To: <20070415013921.GA68262@xor.obsecurity.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704150410.46839.dejan.lesjak@ijs.si> Cc: x11@freebsd.org Subject: Re: Upgrade script X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Apr 2007 02:10:51 -0000 On Sunday 15 April 2007 03:39:22 Kris Kennaway wrote: > One more thing I spotted is that it doesn't handle > non-default X11BASE or LOCALBASE. Probably the way to do this is to > use > > PORTSDIR?=/usr/ports > X11BASE=`make -f ${PORTSDIR}/Mk/bsd.port.mk -V X11BASE` > > or similar. Using bsd.port.mk is so it picks up the default value, > and includes /etc/make.conf to check for override. It also DTRT if > X11BASE is set in the environment. Hmm. I wouldn't use too much automagic in that case. I'm not sure it's good to assume that if someone has changed the defaults that this script will do the right thing for them regardless if it properly detects changed X11BASE/LOCALBASE. I'd rather say they can change variables at beginning of the script. Perhaps printing the message saying that this should be changed if using non-default (and also to change BACKUPDIR) and then ask for confirmation to continue? Dejan