From owner-svn-src-all@freebsd.org Wed Mar 16 22:37:10 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E7CC1AD3D5C; Wed, 16 Mar 2016 22:37:10 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x232.google.com (mail-ig0-x232.google.com [IPv6:2607:f8b0:4001:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B25ADBC0; Wed, 16 Mar 2016 22:37:10 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-ig0-x232.google.com with SMTP id nk17so107234901igb.1; Wed, 16 Mar 2016 15:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=3A4ls+l3VJHUU6MLE3LgA92qCp+yChjH7DVHblEF0YM=; b=vpQu2EUYu87hr8W443updPyWtdJg8ZYeCt+eF8vcsTMiI/VWczItbayTq3qATbHl7e xbwFV8t8Wq7ZUHAvkmgIXB+UMB/9cDT/ACLR61IYPY9Y2oCUbjyOzFhNWFaKlqAKNfDg XE/hNPsbI044YDeHBJufwIksSKAjVY/1WBhg7RYYeHOpxgUSkMHDZo2DOzNwDDrDoywF n5Fo8MIrqnWnqfnT5W/rvUzlp0E76127FCfmnIHifCdIckf3F5vt9++X23AjX9Vq6yOo VKEwyfRDJp++nS/n8VYQPp0gMNdnt3frSGZSxT3ZVPBkY/Bk6HnOIH5Wh8dds+MkT2AJ ivMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=3A4ls+l3VJHUU6MLE3LgA92qCp+yChjH7DVHblEF0YM=; b=lxDCoPLn0L+aRrVgdoYL8OSUXTGAprjTj2DXQ0+iEZr3JSHiqtJ3ObMg/+yxXAFJde yfKzEuFBXYN/Kf3lOtEq2HFJ1Lh3a4916xcWMuhMqTzWx6s9l9H4BtQyP9nX3US+0+rs 92iGQ95jVp52YpIBY0Z86ThdSBg8zOsc1V6TBwN4U+QVcKjx1v16O+oQqi1xtda+NrxA 7BFzjNVOhSdpU7jBjrm4MIuwLvYEp9/Gy8Zuq0vvs1nfEUgFn5wvD3pdp9nOiLUa3aXe OcL9YamkY4SkfDUlL7YC/tMwauG3wrrztPGSX/kEXXZFOpXoMOlOi7v3aAheQzUXUriO ikQA== X-Gm-Message-State: AD7BkJKtejakTF4c8jzmgb+a241dbFqOm16VQZhLRDXtY4evbYW8yOhHyuLv9Z3RYPa4m3HYgnFLrGowrWsurQ== MIME-Version: 1.0 X-Received: by 10.50.157.39 with SMTP id wj7mr31874042igb.61.1458167830046; Wed, 16 Mar 2016 15:37:10 -0700 (PDT) Received: by 10.36.14.19 with HTTP; Wed, 16 Mar 2016 15:37:09 -0700 (PDT) In-Reply-To: <5463538.GTDDlnsCR6@ralph.baldwin.cx> References: <201603151547.u2FFlQKN078643@repo.freebsd.org> <2420759.o4YiE5Za4X@ralph.baldwin.cx> <20160316202738.GL1328@FreeBSD.org> <5463538.GTDDlnsCR6@ralph.baldwin.cx> Date: Wed, 16 Mar 2016 15:37:09 -0700 Message-ID: Subject: Re: svn commit: r296909 - head/sys/ofed/drivers/infiniband/ulp/ipoib From: Adrian Chadd To: John Baldwin Cc: Gleb Smirnoff , Hans Petter Selasky , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2016 22:37:11 -0000 I've fought this problem in USB drivers. Ideally you'd also have the detach path /also/ take said lock and drain anyone currently doing anything active (tx, rx, ioctls, net80211 methods, etc) to completion before continuing. A lot of drivers don't do this very well, or at all. -adrian