From owner-svn-src-all@freebsd.org Wed Mar 2 03:41:55 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 11CDCAC0361; Wed, 2 Mar 2016 03:41:55 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-oi0-x22e.google.com (mail-oi0-x22e.google.com [IPv6:2607:f8b0:4003:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CBD921C6A; Wed, 2 Mar 2016 03:41:54 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-oi0-x22e.google.com with SMTP id m82so144634927oif.1; Tue, 01 Mar 2016 19:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc; bh=4Lc67emTl/NE/WamBRK5XgFgHXvqp5m6u40BChhfd58=; b=wlWj244t2AnHbld15JkP0Oxy9XY+YdY42JE5oSRDR/ssBCnNXfILgP5NTOIbzYGzzF opuCapUt7SfjosNgyeUGAn4HUiURd2fS2M8hRWzHLW7GMtUljI7d3HKj4oNbr0rsBdKf 7n+4o+s13oHKXfAP6dNdGZTmMda84gq/xfJYsSL73InbR4oUPeqcosZCh8TtilajTaGf GCmaXFd/yYKVuBIbmEmTmYwyM61+7+JiYZGnp3MXjMan7EmYzrGQsauJ9OXjD8aZGc/c bvenoBaBpnAqcFCDyhmC3ix2jcjFNvr0g+orLUVU7fXfakmdi6JJh7JCjkKEYRjg9Fyk xB6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=4Lc67emTl/NE/WamBRK5XgFgHXvqp5m6u40BChhfd58=; b=LVcYx5ei+eGIk2NECjfihe8R7nKPcZa8A1yaCqzfP7LLt6mSNJ2Y9DrTRk78jXPu2b vIyhat6ocwl6RXsKIWmTsw0Ew6GGXuHhJ4Ifynqif/cIU0+T5QFg5nrUg4IXePMiPd6N YRES0vvbFkWidyMfIdP835hrYTubEZXllB9gRdnfcUX0ZkGob2APl+6aTH9lycPjmhro vp9YZ+5OF/ZTScUj2LDry6lqB8ciDccW8X8cdHzLWes2M4P/TQ1Iai7mmOMODh1YizJw ZU5qjoH8JizA4S5ewMKN+lxy6XSSO7JlihSOZqVa1oZ73xFSzbb6eP5O0PXX6FPdr0fC e4xg== X-Gm-Message-State: AD7BkJI+xqflkvN9Xnga0yw44grFQGhXNK/Y/BvGiMek0I/nq4MOHLnIbeWKsGe+8D8ArqpTieyEt59n2V5R+g== MIME-Version: 1.0 X-Received: by 10.202.170.70 with SMTP id t67mr4113161oie.60.1456890114054; Tue, 01 Mar 2016 19:41:54 -0800 (PST) Received: by 10.182.72.67 with HTTP; Tue, 1 Mar 2016 19:41:53 -0800 (PST) Reply-To: araujo@FreeBSD.org In-Reply-To: <201603020340.u223eHI1055157@gw.catspoiler.org> References: <201603020328.u223SwLU036267@repo.freebsd.org> <201603020340.u223eHI1055157@gw.catspoiler.org> Date: Wed, 2 Mar 2016 11:41:53 +0800 Message-ID: Subject: Re: svn commit: r296299 - head/sys/contrib/ipfilter/netinet From: Marcelo Araujo To: Don Lewis Cc: Cy Schubert , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 03:41:55 -0000 2016-03-02 11:40 GMT+08:00 Don Lewis : > On 2 Mar, Cy Schubert wrote: > > Author: cy > > Date: Wed Mar 2 03:28:57 2016 > > New Revision: 296299 > > URL: https://svnweb.freebsd.org/changeset/base/296299 > > > > Log: > > Remove redundant NULL pointer comparison. > > > > Reported by: PVS-Studio (V595) in D5245 > > Differential Revision: D5245 > > > > Modified: > > head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c > > > > Modified: head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c > > > ============================================================================== > > --- head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c Wed Mar 2 > 03:26:56 2016 (r296298) > > +++ head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c Wed Mar 2 > 03:28:57 2016 (r296299) > > @@ -1951,10 +1951,6 @@ ipf_p_ftp_epsv(softf, fin, ip, nat, ftp, > > ap += *s++ - '0'; > > } > > > > - if (!s) { > > - return 0; > > -} > > - > > if (*s == '|') > > s++; > > if (*s == ')') > > > > I wonder if that test was meant to be: > if (!*s) { > especially since hitting the end of the string terminates the preceeding > loop? > > > +1 here, looks like it meant to be !*s. Best, -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)