From owner-svn-src-head@freebsd.org Thu Jul 5 12:24:56 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D767A102413B; Thu, 5 Jul 2018 12:24:55 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6564379A47; Thu, 5 Jul 2018 12:24:55 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-it0-x243.google.com with SMTP id p17-v6so12043192itc.2; Thu, 05 Jul 2018 05:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=Dp6U0uteILqI84pqk7vSUiH/tgwKkh22UiHvq9RSVaE=; b=PIe9WODdPAAZSDYu37HejSkqXs41dKOwDisY1yGWB5HPo1bO8Wg3QmhIKhldtxr9W9 B/0d8HitbMbq5vlTh/lrZe0cq3a2DvZ0qOybUG9YkPJ428bPMq1FACj5p0hKk/jtCWo2 +HEQQL24it378HwT7KlTzfKhv0L3cdvYApI0ywQPjoeFx9mJKOJIYy6e7uV9KpafyJy4 vxmXFpaTX3/jPwCRlTNsq0g4Hw3dur8ntcdkCI3+vIIUqYyjUAtuXaA8Wkv2+CYLAyHP r7xT00vDqWiPAvLd2kxFBxoyAaLtduImT1R/rgcauMqamBsn5N9mqqg82HhVZo+LE5Qe opgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=Dp6U0uteILqI84pqk7vSUiH/tgwKkh22UiHvq9RSVaE=; b=mcOb6KzWcAlMc5JNkPLDF+0LV23/gHAcC/AEsBKQ75R6mFSZYdN3O5H5xHymmj5UO2 l6/2K8HB7G2vP1ol3zdJKvF2RJrD1gUC/JTsid0dhrkUl9ddJTDcIE0+nlLdXPW0VQwC xNre461BZJYnN865K+pl98Vfc8qc5cUuQofVCYn4Az9I0U8CTn9Z1no7d/x7bp00tztv y4obietAV+vwdqYzUPcYT62l1ZoHBLdexWG2rFSsyi5/7cXkIu/squJI/iKGpELaP+0d A0NTZYgCjvKc/tcpupwvfaLZBS7JHmeJnoQ54AyYvAfAD4kD9dk+/ToxqbAj8CCzjycJ W56w== X-Gm-Message-State: APt69E03VDeHowmL8XxWoKLscxcyhjw/rs/hrcdQe/Od5FNMD++Fp0YT FiszckW6YcipD977ei00M2bAf5y2Scpu2xU1noI= X-Google-Smtp-Source: AAOMgpff5Yyyq1BHNRyAS1gWt0TCfEZNc6Yg120k5XsLZlgDaM7nLkA3/NqyKEN1jl+DDM8i64MzDKwXLX5Dz19+YHM= X-Received: by 2002:a24:2c49:: with SMTP id i70-v6mr4705198iti.135.1530793494808; Thu, 05 Jul 2018 05:24:54 -0700 (PDT) MIME-Version: 1.0 Sender: antoine.brodin.freebsd@gmail.com Received: by 2002:a02:a495:0:0:0:0:0 with HTTP; Thu, 5 Jul 2018 05:24:54 -0700 (PDT) In-Reply-To: <081170FC-D433-4FE6-87E1-D5470480B971@sigsegv.be> References: <201807010116.w611G35w008185@repo.freebsd.org> <081170FC-D433-4FE6-87E1-D5470480B971@sigsegv.be> From: Antoine Brodin Date: Thu, 5 Jul 2018 12:24:54 +0000 X-Google-Sender-Auth: qTn7tBvINsdt19jlecyGQKtuDao Message-ID: Subject: Re: svn commit: r335833 - in head: share/man/man4 sys/net sys/netpfil/pf To: Kristof Provost Cc: Will Andrews , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 12:24:56 -0000 On Tue, Jul 3, 2018 at 7:42 AM, Kristof Provost wrote: > On 3 Jul 2018, at 7:38, Antoine Brodin wrote: > > On Sun, Jul 1, 2018 at 3:16 AM, Will Andrews wrote: > > Author: will > Date: Sun Jul 1 01:16:03 2018 > New Revision: 335833 > URL: https://svnweb.freebsd.org/changeset/base/335833 > > Log: > pf: remove unused ioctls. > > Several ioctls are unused in pf, in the sense that no base utility > references them. Additionally, a cursory review of pf-based ports > indicates they're not used elsewhere either. Some of them have been > unused since the original import. As far as I can tell, they're also > unused in OpenBSD. Finally, removing this code removes the need for > future pf work to take them into account. > > Reviewed by: kp > Differential Revision: https://reviews.freebsd.org/D16076 > > Modified: > head/share/man/man4/pf.4 > head/sys/net/pfvar.h > head/sys/netpfil/pf/pf_ioctl.c > > Hi, > > This breaks some ports like net/libdnet, please revert or fix the > ports fallout. > > It also uses DIOCCHANGERULE (like sshuttle). > > Do you know of any other failures? > It=E2=80=99d be good to know if reverting just the DIOCCHANGERULE removal= would be > enough to fix all failures, or if there are others that are used as well. The 2 failures I see are libdnet and miniupnpd missing DIOCCHANGERULE, so adding it back may be enough. Antoine