From owner-p4-projects@FreeBSD.ORG  Wed Apr 21 20:10:25 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 06E7E106566C; Wed, 21 Apr 2010 20:10:25 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BF39B1065672
	for <perforce@FreeBSD.org>; Wed, 21 Apr 2010 20:10:24 +0000 (UTC)
	(envelope-from jona@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id AD28E8FC1B
	for <perforce@FreeBSD.org>; Wed, 21 Apr 2010 20:10:24 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o3LKAO76067903
	for <perforce@FreeBSD.org>; Wed, 21 Apr 2010 20:10:24 GMT
	(envelope-from jona@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o3LKAOuO067901
	for perforce@freebsd.org; Wed, 21 Apr 2010 20:10:24 GMT
	(envelope-from jona@FreeBSD.org)
Date: Wed, 21 Apr 2010 20:10:24 GMT
Message-Id: <201004212010.o3LKAOuO067901@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jona@FreeBSD.org using -f
From: Jonathan Anderson <jona@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 177190 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Apr 2010 20:10:25 -0000

http://p4web.freebsd.org/@@177190?ac=10

Change 177190 by jona@jona-belle-freebsd8 on 2010/04/21 20:10:09

	No, we don't really need this

Affected files ...

.. //depot/projects/trustedbsd/capabilities/src/lib/libcapsicum/libcapsicum_fdlist.c#11 edit

Differences ...

==== //depot/projects/trustedbsd/capabilities/src/lib/libcapsicum/libcapsicum_fdlist.c#11 (text+ko) ====

@@ -31,7 +31,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $P4: //depot/projects/trustedbsd/capabilities/src/lib/libcapsicum/libcapsicum_fdlist.c#10 $
+ * $P4: //depot/projects/trustedbsd/capabilities/src/lib/libcapsicum/libcapsicum_fdlist.c#11 $
  */
 
 #include <sys/mman.h>
@@ -467,12 +467,6 @@
 	LOCK(lfp);
 	lfsp = lfp->lf_storage;
 
-	/* Do we really need to do this? */
-	if (lfsp->count == 0) {
-		UNLOCK(lfp);
-		return (0);
-	}
-
 	/*
 	 * Identify the highest source file descriptor we care about so that
 	 * when we play the dup2() rearranging game, we don't overwrite any