Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Apr 2010 20:10:24 GMT
From:      Jonathan Anderson <jona@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 177190 for review
Message-ID:  <201004212010.o3LKAOuO067901@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@177190?ac=10

Change 177190 by jona@jona-belle-freebsd8 on 2010/04/21 20:10:09

	No, we don't really need this

Affected files ...

.. //depot/projects/trustedbsd/capabilities/src/lib/libcapsicum/libcapsicum_fdlist.c#11 edit

Differences ...

==== //depot/projects/trustedbsd/capabilities/src/lib/libcapsicum/libcapsicum_fdlist.c#11 (text+ko) ====

@@ -31,7 +31,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $P4: //depot/projects/trustedbsd/capabilities/src/lib/libcapsicum/libcapsicum_fdlist.c#10 $
+ * $P4: //depot/projects/trustedbsd/capabilities/src/lib/libcapsicum/libcapsicum_fdlist.c#11 $
  */
 
 #include <sys/mman.h>
@@ -467,12 +467,6 @@
 	LOCK(lfp);
 	lfsp = lfp->lf_storage;
 
-	/* Do we really need to do this? */
-	if (lfsp->count == 0) {
-		UNLOCK(lfp);
-		return (0);
-	}
-
 	/*
 	 * Identify the highest source file descriptor we care about so that
 	 * when we play the dup2() rearranging game, we don't overwrite any



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201004212010.o3LKAOuO067901>