From owner-freebsd-ports@FreeBSD.ORG  Mon Oct  1 21:08:07 2007
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E6F2B16A421
	for <ports@freebsd.org>; Mon,  1 Oct 2007 21:08:07 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from heff.fud.org.nz (203-109-251-39.static.bliink.ihug.co.nz
	[203.109.251.39])
	by mx1.freebsd.org (Postfix) with ESMTP id 922AF13C48A
	for <ports@freebsd.org>; Mon,  1 Oct 2007 21:08:07 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: by heff.fud.org.nz (Postfix, from userid 1001)
	id 700B91CC58; Tue,  2 Oct 2007 09:56:35 +1300 (NZDT)
Date: Tue, 2 Oct 2007 09:56:35 +1300
From: Andrew Thompson <thompsa@FreeBSD.org>
To: Ulrich Spoerlein <uspoerlein@gmail.com>
Message-ID: <20071001205635.GA34222@heff.fud.org.nz>
References: <20071001194035.GA1462@roadrunner.spoerlein.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071001194035.GA1462@roadrunner.spoerlein.net>
User-Agent: Mutt/1.5.13 (2006-08-11)
Cc: ports@freebsd.org, Sam Leffler <sam@errno.com>,
	Tai-hwa Liang <avatar@mmlab.cse.yzu.edu.tw>,
	Sepherosa Ziehau <sephe@FreeBSD.org>
Subject: Re: struct wi_req: how to deal with removal, affects multiple ports
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Oct 2007 21:08:08 -0000

On Mon, Oct 01, 2007 at 09:40:35PM +0200, Ulrich Spoerlein wrote:
> Hi,
> 
> on July 11th you removed the definition for struct wi_req on -CURRENT
> from sys/dev/wi/if_wavelan_ieee.h with the following commit message
> 
> revision 1.21
> date: 2007/07/11 21:25:48;  author: thompsa;  state: Exp;  lines: +2 -0
> Now that wicontrol has been removed from the base system the corresponding
> ioctls can be removed. These have been #ifdef'd out and left as a reference in
> case any of the RIDs need to be turned into sysctls at a later date.
> 
> Reviewed by:    sam, avatar
> Approved by:    re (kensmith)
> 
> I don't know why, but recently at least the ports xwlans and wmwifi fail
> to build because of the missing definition, I guess. bsd-airtools has
> recently been flagged as broken, too. Presumably due to the same reason.

Up until that commit wi(4) was the only driver to support the
SIOCGWAVELAN calls, now it has been totally removed in favour of the
net80211 systems.

> How should these ports deal with this? Both are calling SIOCGWAVELAN
> with wi_type set to WI_RID_COMMS_QUALITY.

I guess these ports should be updated to use the IEEE80211_IOC_SCAN_REQ
and IEEE80211_IOC_SCAN_RESULTS ioctls. These are driver independent and
supported by all the wireless drivers, src/sbin/ifconfig/ifieee80211.c
is a good reference.

I see that wmwifi-bsd.patch from wmwifi could be updated reasonably
easy, I can help if you like.


Andrew