From owner-svn-src-all@freebsd.org Sun Sep 1 21:13:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D16FFE63E3; Sun, 1 Sep 2019 21:13:12 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46M5Xm0pmvz3MVt; Sun, 1 Sep 2019 21:13:11 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f54.google.com with SMTP id x4so25267046iog.13; Sun, 01 Sep 2019 14:13:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=j4x2rkD/N2+/1BgDPVq+17uCfFU1QGqiw1oAL8bt258=; b=hpC5ZBuQBJBF0KT4CEFiRUQ9Ps8lKZjDmXESsi0RaTkj9IJ4QNwPVq2Spl9qaYW+Xa dH/ojxCZA1DM6z85jxpKOgYWhkUiMh751XYNZtm27Uv6F4LZrsRCjqw9HwGOm+1bFMxL KdaGebB0l2XcUlx9QX+qEdlqkrUuGAzWeWpxQaKJbXhM4s2ijpP232oXt4OfP3kRTor9 rdu0i3srlRuavFApxDhzEz1xWElUrPuwd2+/w9Oke1BZJl8GYSQlMLnrmJma3sSelvIe loU4Oeb6fgelo9Nel+mRsmrOhX1HeQ1/BMK0jg6jA//PWS3ay0iK4dCiPNV9bhaeXKZ6 iDxw== X-Gm-Message-State: APjAAAUv5o4EKgI2P4h4mOjRG2dRwAjjSAQ0Ydsw+LwAzQR4Fz/upuR9 TkhTYTqscn0w+J6WGxtXtyYr/HM7 X-Google-Smtp-Source: APXvYqz4v59EHlhW9RAwxxT1eAlzsi//HbMz1itDY27rY3/dEXFl4aOjHeMRzdPzpaGet6O/20Erzg== X-Received: by 2002:a6b:ea02:: with SMTP id m2mr19052325ioc.155.1567372390831; Sun, 01 Sep 2019 14:13:10 -0700 (PDT) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com. [209.85.166.42]) by smtp.gmail.com with ESMTPSA id c9sm10749928ioc.22.2019.09.01.14.13.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Sep 2019 14:13:10 -0700 (PDT) Received: by mail-io1-f42.google.com with SMTP id n197so23407620iod.9; Sun, 01 Sep 2019 14:13:10 -0700 (PDT) X-Received: by 2002:a5e:dc0b:: with SMTP id b11mr5088431iok.231.1567372390359; Sun, 01 Sep 2019 14:13:10 -0700 (PDT) MIME-Version: 1.0 References: <201909011612.x81GC5DW097846@repo.freebsd.org> <201909011932.x81JWYts004074@slippy.cwsent.com> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sun, 1 Sep 2019 14:12:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r351659 - in head: contrib/libc++/include contrib/netbsd-tests/lib/libc/ssp gnu/lib/libssp include lib/libc/stdio To: Cy Schubert Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46M5Xm0pmvz3MVt X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-5.41 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; HAS_REPLYTO(0.00)[cem@freebsd.org]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.988,0]; RCVD_IN_DNSWL_NONE(0.00)[54.166.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-2.42)[ip: (-6.43), ipnet: 209.85.128.0/17(-3.34), asn: 15169(-2.31), country: US(-0.05)]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2019 21:13:12 -0000 Sorry. Accidentally hit send instead of clicking in the edit box. On Sun, Sep 1, 2019 at 2:12 PM Conrad Meyer wrote: > > On Sun, Sep 1, 2019 at 12:32 PM Cy Schubert wrote: > > > > In message <201909011612.x81GC5DW097846@repo.freebsd.org>, Ed Maste writes: > > > Author: emaste > > > Date: Sun Sep 1 16:12:05 2019 > > > New Revision: 351659 > > > URL: https://svnweb.freebsd.org/changeset/base/351659 > > > > > > Log: > > > libc: remove gets > > > > > > gets is unsafe and shouldn't be used (for many years now). Leave it in > > > the existing symbol version so anything that previously linked aginst it > > > still runs, but do not allow new software to link against it. > > > > > > (The compatability/legacy implementation must not be static so that > > > the symbol and in particular the compat sym gets@FBSD_1.0 make it > > > into libc.) > > > > > > PR: 222796 (exp-run) > > > Reported by: Paul Vixie > > > Reviewed by: allanjude, cy, eadler, gnn, jhb, kib, ngie (some earlie > > > r) > > > Relnotes: Yes > > > Sponsored by: The FreeBSD Foundation > > > Differential Revision: https://reviews.freebsd.org/D12298 > > > > > > Modified: > > > head/contrib/libc++/include/cstdio > > > head/contrib/netbsd-tests/lib/libc/ssp/h_gets.c > > > head/gnu/lib/libssp/Makefile > > > head/include/stdio.h > > > head/lib/libc/stdio/fgets.3 > > > head/lib/libc/stdio/gets.c > > > head/lib/libc/stdio/stdio.3 > > > > Should we encourage the use of gets_s() in the man page or in other doc? > > > > This probably requires a __FreeBSD_version bump. > > > > > > -- > > Cheers, > > Cy Schubert > > FreeBSD UNIX: Web: http://www.FreeBSD.org > > > > The need of the many outweighs the greed of the few. > > > > > >