Date: Sun, 21 Aug 2016 17:25:13 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209742] devel/godot: Update to 2.1; add devel/godot-tools port Message-ID: <bug-209742-13-whArXxldGH@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-209742-13@https.bugs.freebsd.org/bugzilla/> References: <bug-209742-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209742 Jan Beich <jbeich@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173905|0 |1 is obsolete| | --- Comment #73 from Jan Beich <jbeich@FreeBSD.org> --- Comment on attachment 173905 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D173905 style cleanup (In reply to Kurt Jaeger from comment #69) > Both variants testbuild fine. Now, which one can be committed ? Ignore my patch per "perfect is the enemy of good". Except for sorting USES= and rewording AUDIO_DESC it's an aggressive approach to style that can go in a separate bug. (In reply to lightside from comment #68) > Because PKGBASE has different value: ${PKGNAMEPREFIX}${PORTNAME}${PKGNAME= SUFFIX} Which is more correct if devel/linux-godot-tools ever appears. ;) > This is just an variable, which not used in port's framework,=20 GODOTFILE isn't but PKGNAMESUFFIX is. If you're relying on parts of the pac= kage name then why not take advantage of it more. > i.e. to change it in one place, instead of many places, when needed. Before the update here lands GODOTFILE isn't defined in devel/godot. Droppi= ng it now wouldn't affect |svn blame|. > I think, this statement is for upstream... Upstream doesn't use KERN_PROC_PATHNAME. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209742-13-whArXxldGH>