From owner-cvs-all Tue Oct 22 8:37:25 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D76837B408; Tue, 22 Oct 2002 08:37:19 -0700 (PDT) Received: from mta03bw.bigpond.com (mta03bw.bigpond.com [139.134.6.86]) by mx1.FreeBSD.org (Postfix) with ESMTP id 792FA43E6E; Tue, 22 Oct 2002 08:37:17 -0700 (PDT) (envelope-from darrenr@reed.wattle.id.au) Received: from CPE-61-9-164-106.vic.bigpond.net.au ([144.135.24.81]) by mta03bw.bigpond.com (Netscape Messaging Server 4.15 mta03bw Jul 16 2002 22:47:55) with SMTP id H4E3DX00.FVT; Wed, 23 Oct 2002 01:37:09 +1000 Received: from CPE-203-51-143-179.vic.bigpond.net.au ([203.51.143.179]) by bwmam05.mailsvc.email.bigpond.com(MailRouter V3.0n 44/11201339); 23 Oct 2002 01:37:09 Received: (from root@localhost) by CPE-61-9-164-106.vic.bigpond.net.au (8.11.0/8.11.0) id g8LFqHl19442; Sun, 22 Sep 2002 01:52:17 +1000 From: Darren Reed Message-Id: <200209211550.BAA28628@avalon.reed.wattle.id.au> Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c In-Reply-To: <38166.1032604735@critter.freebsd.dk> To: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, jhb@FreeBSD.org Date: Sun, 22 Sep 2002 01:50:57 +1000 Cc: Darren Reed , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, John@reed.wattle.id.au, Baldwin X-Mailer: ELM [version 2.4ME+ PL99 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In some email I received from Poul-Henning Kamp, sie wrote: [...] > If nothing else you should thank me for making it easier for you > to grep out the future victims of your crusade. Thank you for making my crusade easier. > >That said, would anyone object to me adding the macro below to FreeBSD > >in sys/mbuf.h ? It's a tad gross because of the local variables :/ > > Yes, I would very much object to that, it is butt-ugly, there is > no performance need for this to be inlined, and your entire interest > in this seems to be more about ego-restoration than about code > readability or quality. You've never had anyone tell you that BPF is slow and that to make it useful in certain environments, lots of changes were needed, have you ? Anyway, you don't have final say here but I thank you for and note your opinion. Darren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message