From owner-svn-ports-all@freebsd.org  Wed Nov 13 09:34:06 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 296461ABC8A;
 Wed, 13 Nov 2019 09:34:06 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 47CfZQ0Jtnz3JZh;
 Wed, 13 Nov 2019 09:34:06 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id D6374AF45; Wed, 13 Nov 2019 09:34:05 +0000 (UTC)
Date: Wed, 13 Nov 2019 09:34:05 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Tobias Kortkamp <tobik@freebsd.org>
Cc: Pietro Cerutti <gahr@freebsd.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r517341 - head/x11-wm/e16
Message-ID: <20191113093405.GB34207@FreeBSD.org>
References: <201911121700.xACH0fpg045907@repo.freebsd.org>
 <20191113092534.GA61113@urd.tobik.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191113092534.GA61113@urd.tobik.me>
User-Agent: Mutt/1.11.4 (2019-03-13)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Nov 2019 09:34:06 -0000

On Wed, Nov 13, 2019 at 10:25:34AM +0100, Tobias Kortkamp wrote:
> On Tue, Nov 12, 2019 at 05:00:41PM +0000, Pietro Cerutti wrote:
> > Author: gahr
> > Date: Tue Nov 12 17:00:40 2019
> > New Revision: 517341
> > URL: https://svnweb.freebsd.org/changeset/ports/517341
> > 
> > Log:
> >   x11-wm/e16: update to 1.0.21, rework OPTIONS
> >   
> > ...
> > -OPTIONS_DEFINE=		DOCS NLS PANGO SOUND
> > +OPTIONS_DEFINE=		DOCS NLS PANGO
> > +OPTIONS_RADIO=		SOUND SOUNDLOADER
> > +OPTIONS_RADIO_SOUND=	PULSEAUDIO SNDIO
> > +OPTIONS_RADIO_SOUNDLOADER=	SNDFILE AUDIOFILE
> >  OPTIONS_SUB=		yes
> > ...
> > +# Double check SOUND and SOUNDLOADER
> > +E16_SOUND=	${PORT_OPTIONS:MPULSEAUDIO}${PORT_OPTIONS:MSNDIO}
> > +E16_SNDLDR=	${PORT_OPTIONS:MSNDFILE}${PORT_OPTIONS:MAUDIOFILE}
> > +.if !empty(E16_SOUND) && empty(E16_SNDLDR)
> > +IGNORE=	sound support requires a sound loader
> > +.endif
> > +.if empty(E16_SOUND) && !empty(E16_SNDLDR)
> > +IGNORE=	sound loader only makes sense with sound support
> > +.endif
> 
> could you please look this over again:
> 
> - USES is set twice which does not make sense
> - None of the *_CONFIGURE_{ENABLE,OFF,ON} or *_USES helpers do anything
>   since CONFIGURE_ARGS and USES are overwritten again after including
>   bsd.port.options.mk.

The entire "rework OPTIONS" code is a mess and should be fixed for good.
Perhaps Pietro might want to find an extra pair of eyes to review his work
prior to committing, or at leaset rehash /usr/ports/Mk/bsd.options.mk.

./danfe