From owner-svn-src-all@freebsd.org Wed May 22 15:39:58 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ABF5D15AED87; Wed, 22 May 2019 15:39:58 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yw1-xc30.google.com (mail-yw1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3811C8B343; Wed, 22 May 2019 15:39:58 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-yw1-xc30.google.com with SMTP id w21so1014650ywd.6; Wed, 22 May 2019 08:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=z50MBqQ/LytoXX4l1yIAwSRIhs+tDDFAeLu17NLBKgs=; b=mtyZyNvt+c2HjuPLLF3Tz0mQz2ERkmm0eSdFwnMCrHUOC7tOV9Qs+yKxct6LBjd67i kUI88gd2QLfzmMXuNIxFKVVwiI0ucUIjq7+nZxN5jYk7IgdLuRVpGJOZQehag+dPUJZ9 6TTwH7g3OqwcVl1Ahv7XKHISQ7nrMnwsXhpUUMhDmlAves9NIhWQSFLDats07qkOHotJ ytGY8uu5DyFJPxRt41mzUid8adn6/YCq6+NajXp25AT8NC7CHJGdbYyXbV8fYN2yPvUq xnNDnE5uLcb+meGLRg30R1oUjLuK3iHlOmBAR68WUEfc1t0VtdLmStz7vMgq4B3CK/Kz HUeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=z50MBqQ/LytoXX4l1yIAwSRIhs+tDDFAeLu17NLBKgs=; b=Ls7U0QTi2m9xt0tb3zChJQeZE21g01jLOZJzsDj2IfOoSUieFXeGv5DkHcRLUW1ufL nE/apAa/XyiXSVPiQlwgs7L5l5KFEp/kQnmZ/z5QRZLEbxo+TNiX2XrMYU0bugP7V3g5 Zyz70rRBxFXx7n8ADRp/xzPBWPU0hDWdeRQAsI9dN8hGpQO0kA168h1tAk03lLxyRUAY WaA1ndl7niVUuRC70owmsID2M1UvInJlhhtpSuJKHGiEPcRhad0yDMVIo1Wk2QkrGIc/ Hs/rwzmyp2CaCRaP+x5QjLY5NInS4Hj1bt08PIW9sYvd6VH9Y/aYxP8lUNsx0YThRKpX TU/w== X-Gm-Message-State: APjAAAWG8tZ3hEK/1PbrSpLJ9Ubx2r5le8NCUf9sT5w+NOpHzKL3XOtG LSMZWpLiKMr6M+/MjkzFdyLpTSIEAbo= X-Google-Smtp-Source: APXvYqxSzSZy4PbaRloix06l+3YA4l7GsmaQeIdQXiqCgt4W0bgn8dJAIhRdNCrDlffOG/Vem6Zwug== X-Received: by 2002:a81:5e8b:: with SMTP id s133mr4438935ywb.149.1558539597423; Wed, 22 May 2019 08:39:57 -0700 (PDT) Received: from mavoffice.ixsystems.com ([12.189.233.129]) by smtp.gmail.com with ESMTPSA id o76sm5221529ywd.49.2019.05.22.08.39.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 08:39:56 -0700 (PDT) Sender: Alexander Motin Subject: Re: svn commit: r345815 - in head: lib/libcam sys/cam sys/cam/nvme To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201904021937.x32JbrRk067921@repo.freebsd.org> <20190522151028.GA29205@FreeBSD.org> From: Alexander Motin Openpgp: preference=signencrypt Autocrypt: addr=mav@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFOzxAwBCADkPrax0pI2W/ig0CK9nRJJwsHitAGEZ2HZiFEuti+6/4UVxj81yr4ak/4g 9bKUyC7rMEAp/ZHNhd+MFCPAAcHPvtovnfykqE/vuosCS3wlSLloix2iKVLks0CwbLHGAyne 46lTQW74Xl/33c3W1Z6d8jD9gVFT/xaVzZ0U9xdzOmsYAZaAj4ki0tuxO9F7L+ct9grRe7iP g8t9hai7BL4ee3VRwk2JXnKb7UvBiVITKYWKz1jRvZIrjPokgEcCLOSlv7x/1kjuFnj3xWZU 7HSFFT8J93epBbrSSCsYsppIk2fZH41kaaFXsMQfTPH8wkeM6qwrvOh4HiQM08R+9tThABEB AAHNIUFsZXhhbmRlciBNb3RpbiA8bWF2QEZyZWVCU0Qub3JnPsLAlwQTAQoAQQIbAwULCQgH AwUVCgkICwUWAwIBAAIeAQIXgAIZARYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMKuBQkN McyiAAoJEIMYw5VbqyJ/tuUIAOG3ONOSNYqjK4eTZ1TVh9jdUBAhWk5nhDFnODN49Wj0AbYm 7aIqy8O1hnCDSZG5LttjSAo3UfXJZDKQM0BLb0gpRMBnAYqO6tdolLNqAbPGJBnGoPjsh24y 6KcbDaNnis+lD4GwPXwQM+92wZGhCUFElPV9NciZGVS65TNIgk7X+yEjjhD1MSWKKijZ1r9Z zIt4OzUTxxNOvzdlABZS88nNRdJkatOQJPmFdd1mpP6UzTNCiLUo1pIqOEtJgvVVDYq5WHY6 tciWWYdmZG/tIBexJmv2mV2OLVjXR6ZeKmntVH14H72/wRHJuYHQC+r5SVRcWWayrThsY6jZ Yr4+raTOwE0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6Z AXgDtmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8Flv mI/c40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt 3ytU8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZ R1EdEIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm5 9R8AEQEAAcLAZQQYAQoADwUCU7PEDAIbDAUJBaOagAAKCRCDGMOVW6sif7FRB/4k9y/GaGqU fcJiXdQHRAKHCUvbKMFgeEDHOg33qx+POS2Ah85/PXVa2jYBldCZDmYc+zl48aEMd163a7s3 0gJaB7CYElwxlKUk6c+5gwoYIJuJJzSzW0JzSD5ch7RIRxbfxrKdsiHrUW8AeduZWzlK6VaW RmWILgLmxfLdhEVFWxbr99GSeVFZaZwn6tl/8CvBcgYoARvJvl0V5zS1akQfEISYkwL9EfUI W44EOHranL5qUXkedXBYp6fRsooGrIimfwYxaC8FbXhk3FMgMjDMRiVq4POHo1iGeYETsUrL NM6184E25gPVtX2fb3RhM8Xh6BkwCZ6ZYbQ+AcD4F/cKwsB8BBgBCgAmAhsMFiEE6YzzxOac w80OV51VgxjDlVurIn8FAllgwtgFCQ0xzMwACgkQgxjDlVurIn9OqAf9FAcKWS95wTTbraXA qg/+bQyHgjlMtGCgkmfxLsbUGeqiFgmSIuoDrF7q6sYPs6p00CXXZRuuNZt0lX7O95re8mgz gxm5iJisZpdbHMVepYlw/AxT2wCHwxGCEe64Lm+A9vjlOd+3D3/6fSLwZ9WFCE6p6lQZ1CDg 09xe+JKSgC+KDqmn0tzGKyfSCuhRAq3XkZyxL1hxBaDeP0eeKlzoy7jXodf3wVvXXc0cmpza B5McuRHK4EU6jIioHo30YqPM4AjPHGxV2X1N6/Aayungzj9EXNZtKCxs6dsTvjniWa5VkZ9F 4SOdSbxEen1DZRYpeWnd7GVmO86n+5USkKCXPg== Message-ID: <66c4b8cb-fca1-da79-fb35-86742e549e60@FreeBSD.org> Date: Wed, 22 May 2019 11:39:56 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20190522151028.GA29205@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3811C8B343 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.970,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 15:39:58 -0000 On 22.05.2019 11:10, Alexey Dokuchaev wrote: > On Tue, Apr 02, 2019 at 07:37:53PM +0000, Alexander Motin wrote: >> New Revision: 345815 >> URL: https://svnweb.freebsd.org/changeset/base/345815 >> >> Log: >> Make cam_error_print() decode NVMe commands. >> >> Modified: head/sys/cam/nvme/nvme_xpt.c >> ... >> @@ -769,11 +769,13 @@ nvme_proto_debug_out(union ccb *ccb) >> { >> char cdb_str[(sizeof(struct nvme_command) * 3) + 1]; >> >> - if (ccb->ccb_h.func_code != XPT_NVME_IO) >> + if (ccb->ccb_h.func_code != XPT_NVME_IO || >> + ccb->ccb_h.func_code != XPT_NVME_ADMIN) >> return; > > PVS Studio complains that "Expression is always true. Probably the '&&' > operator should be used here". Can you take a look? Fixed. Thank you. -- Alexander Motin