From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 31 08:10:09 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A760106566B for ; Wed, 31 Mar 2010 08:10:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E0C708FC21 for ; Wed, 31 Mar 2010 08:10:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2V8A89b053272 for ; Wed, 31 Mar 2010 08:10:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2V8A8Hd053269; Wed, 31 Mar 2010 08:10:08 GMT (envelope-from gnats) Resent-Date: Wed, 31 Mar 2010 08:10:08 GMT Resent-Message-Id: <201003310810.o2V8A8Hd053269@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Garrett Cooper Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 253E11065676 for ; Wed, 31 Mar 2010 08:04:58 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 143EC8FC1E for ; Wed, 31 Mar 2010 08:04:58 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o2V84vO3073141 for ; Wed, 31 Mar 2010 08:04:57 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o2V84v41073140; Wed, 31 Mar 2010 08:04:57 GMT (envelope-from nobody) Message-Id: <201003310804.o2V84v41073140@www.freebsd.org> Date: Wed, 31 Mar 2010 08:04:57 GMT From: Garrett Cooper To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/145232: [patch] Fix compiler warning with libficl by exporting dictCheckThreshold in ficl.h X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2010 08:10:09 -0000 >Number: 145232 >Category: kern >Synopsis: [patch] Fix compiler warning with libficl by exporting dictCheckThreshold in ficl.h >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 31 08:10:08 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Garrett Cooper >Release: 9-CURRENT >Organization: Cisco Systems, Inc. >Environment: FreeBSD bayonetta.local 9.0-CURRENT FreeBSD 9.0-CURRENT #5 r205310: Sat Mar 20 01:32:51 PDT 2010 gcooper@bayonetta.local:/usr/obj/usr/src/sys/BAYONETTA amd64 >Description: There's a compiler warning that pops up when you compile sys/boot/ficl: cc -O2 -pipe -fno-strict-aliasing -pipe -O2 -march=nocona -ffreestanding -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -std=gnu99 -m32 -march=i386 -I. -I/scratch/freebsd/releng_8/sys/boot/ficl -I/scratch/freebsd/releng_8/sys/boot/ficl/i386 -I/scratch/freebsd/releng_8/sys/boot/ficl/../common -c words.c words.c: In function 'colon': words.c:467: warning: implicit declaration of function 'dictCheckThreshold' This patch takes care of the warning by exporting dictCheckThreshold via ficl.h >How-To-Repeat: make -C sys/boot/ficl clean all >Fix: Patch attached with submission follows: Index: /usr/src/sys/boot/ficl/ficl.h =================================================================== --- /usr/src/sys/boot/ficl/ficl.h (revision 205872) +++ /usr/src/sys/boot/ficl/ficl.h (working copy) @@ -757,6 +757,7 @@ int dictCellsAvail (FICL_DICT *pDict); int dictCellsUsed (FICL_DICT *pDict); void dictCheck (FICL_DICT *pDict, FICL_VM *pVM, int n); +void dictCheckThreshold(FICL_DICT* dp); FICL_DICT *dictCreate(unsigned nCELLS); FICL_DICT *dictCreateHashed(unsigned nCells, unsigned nHash); FICL_HASH *dictCreateWordlist(FICL_DICT *dp, int nBuckets); >Release-Note: >Audit-Trail: >Unformatted: