From owner-p4-projects@FreeBSD.ORG  Tue Dec  4 20:39:56 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2D48816A41A; Tue,  4 Dec 2007 20:39:56 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BAEF016A417;
	Tue,  4 Dec 2007 20:39:55 +0000 (UTC)
	(envelope-from brooks@lor.one-eyed-alien.net)
Received: from lor.one-eyed-alien.net (cl-162.ewr-01.us.sixxs.net
	[IPv6:2001:4830:1200:a1::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 559CE13C467;
	Tue,  4 Dec 2007 20:39:55 +0000 (UTC)
	(envelope-from brooks@lor.one-eyed-alien.net)
Received: from lor.one-eyed-alien.net (localhost [127.0.0.1])
	by lor.one-eyed-alien.net (8.14.1/8.13.8) with ESMTP id lB4Kds8D043521; 
	Tue, 4 Dec 2007 14:39:54 -0600 (CST)
	(envelope-from brooks@lor.one-eyed-alien.net)
Received: (from brooks@localhost)
	by lor.one-eyed-alien.net (8.14.1/8.13.8/Submit) id lB4KdsD5043520;
	Tue, 4 Dec 2007 14:39:54 -0600 (CST) (envelope-from brooks)
Date: Tue, 4 Dec 2007 14:39:54 -0600
From: Brooks Davis <brooks@freebsd.org>
To: Hans Petter Selasky <hselasky@freebsd.org>
Message-ID: <20071204203954.GA43394@lor.one-eyed-alien.net>
References: <200712042035.lB4KZqBA000505@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU"
Content-Disposition: inline
In-Reply-To: <200712042035.lB4KZqBA000505@repoman.freebsd.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0
	(lor.one-eyed-alien.net [127.0.0.1]);
	Tue, 04 Dec 2007 14:39:54 -0600 (CST)
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 130185 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Dec 2007 20:39:56 -0000


--azLHFNyN32YCQGCU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 04, 2007 at 08:35:52PM +0000, Hans Petter Selasky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=3D130185
>=20
> Change 130185 by hselasky@hselasky_laptop001 on 2007/12/04 20:35:00
>=20
> =09
> 	Compile fixes for Sparc64.
> =09
> 	The change to "usb_transfer.c" is actually
> 	a bug fix.

> =3D=3D=3D=3D //depot/projects/usb/src/sys/dev/usb/ums.c#31 (text+ko) =3D=
=3D=3D=3D
>=20
> @@ -186,7 +186,7 @@
> =20
>  		if (len > sizeof(sc->sc_temp)) {
>  			DPRINTF(5, "truncating large packet to %d bytes\n",
> -			    sizeof(sc->sc_temp));
> +			    (int)sizeof(sc->sc_temp));

You should use %zu to print size_t's, not cast them to ints.

-- Brooks

--azLHFNyN32YCQGCU
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)

iD8DBQFHVbsZXY6L6fI4GtQRAvGZAKCqQ215Ex9w0cScUTetnH5qZ9/KGQCePZYw
2TCtKVPgi5/JKEMzwYPI/uo=
=q87/
-----END PGP SIGNATURE-----

--azLHFNyN32YCQGCU--