From owner-freebsd-net@FreeBSD.ORG Thu Jul 9 16:38:12 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8222C10656AD for ; Thu, 9 Jul 2009 16:38:12 +0000 (UTC) (envelope-from silby@silby.com) Received: from niwun.pair.com (niwun.pair.com [209.68.2.70]) by mx1.freebsd.org (Postfix) with SMTP id F12358FC25 for ; Thu, 9 Jul 2009 16:38:10 +0000 (UTC) (envelope-from silby@silby.com) Received: (qmail 93488 invoked by uid 3193); 9 Jul 2009 16:11:26 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 9 Jul 2009 16:11:26 -0000 Date: Thu, 9 Jul 2009 12:11:26 -0400 (EDT) From: Mike Silbersack X-X-Sender: silby@niwun.pair.com To: sthaug@nethelp.no In-Reply-To: <20090708.141630.78743642.sthaug@nethelp.no> Message-ID: References: <20090708.141630.78743642.sthaug@nethelp.no> User-Agent: Alpine 1.00 (BSF 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-net@freebsd.org, robert Subject: Re: Missing MFC of Silbersack/Klein IP id generation? X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2009 16:38:15 -0000 On Wed, 8 Jul 2009, sthaug@nethelp.no wrote: > According to the comments for rev. 1.10 of netinet/ip_id.c, from > > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/ip_id.c > > this is to be MFCed after 2 weeks (i.e. 2 weeks after 6. February 2008). > > And yet here we are in July 2009, and 7-STABLE shows no sign of this > version of the IP id generation code but instead has the version that > Amit Klein showed had problems, > > http://www.trusteer.com/docs/OpenBSD_DNS_Cache_Poisoning_and_Multiple_OS_Predictable_IP_ID_Vulnerability.pdf > > Is this a deliberate choice? > > Steinar Haug, Nethelp consulting, sthaug@nethelp.no This is a case of me losing track of time and not getting around to the merge. As far as I know the code in question works properly. I will try to merge it soon. If another committer would like to handle the merge for me to get it done sooner, please speak up. :) Sorry for the delay, Mike "Silby" Silbersack