From owner-svn-src-projects@FreeBSD.ORG Wed Feb 6 14:01:43 2013 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id EAC9321C for ; Wed, 6 Feb 2013 14:01:43 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-ve0-f176.google.com (mail-ve0-f176.google.com [209.85.128.176]) by mx1.freebsd.org (Postfix) with ESMTP id 9EF51B7E for ; Wed, 6 Feb 2013 14:01:43 +0000 (UTC) Received: by mail-ve0-f176.google.com with SMTP id cz10so1157171veb.7 for ; Wed, 06 Feb 2013 06:01:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=E86KiRBqyzpHWQuR5uln107GyBvG7DZ5QJ/kYM10dag=; b=Ss/NszwTpYTtXf0/w8vpciHoDNyi5m1U+VAIiNlqp8WAi/lgnEEQUPOHgn0yeAQLXS GdAaMUjHBLzsMfgPxQKKHZMHAHXL+GmzMM+z6MIRGwIy7J1RDhWAWQ0tkwN0fZH5/WFG gH6X2Frp251ZUNHQXzPmoXMfq9U5j15cafXQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=E86KiRBqyzpHWQuR5uln107GyBvG7DZ5QJ/kYM10dag=; b=me+Uzj0H1tLhhCXzTRofmNMCGx+It8M86dLdb0pyyTP0OMhvfLEcm1DG01E97EKgUI 8q2HFFs2rtzXsELzxOSDpnvLjEZSflM8trwmIzLNuLKy4D/trO9Qb9tDyzmS8Cl5s32w 65//MArURp7322RUBh6R9NvCbdaYoMJgrh9dBM43MICFXkUxlh/1lUawiZUouhCdbkX6 zIyFf7R6LIm2uxDq64Sctvq2RqE96Ar5sBmmMGoZhXTx6KRXK6Srp1GrSoAUTCdEPsMS yo+In3jwXJs/qRqdVzqFp+TQBQK3128NAMJ6p4q/2UXBWDtUPppwOEYk/JFzs90mRSy4 LauA== X-Received: by 10.58.97.165 with SMTP id eb5mr29398157veb.40.1360159296827; Wed, 06 Feb 2013 06:01:36 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.220.207.16 with HTTP; Wed, 6 Feb 2013 06:01:05 -0800 (PST) In-Reply-To: <51125D8C.3050405@mu.org> References: <201302060436.r164awc3073100@svn.freebsd.org> <51125D8C.3050405@mu.org> From: Eitan Adler Date: Wed, 6 Feb 2013 09:01:05 -0500 X-Google-Sender-Auth: o_g4RF9BoeZixML6ndoYW_sNfVQ Message-ID: Subject: Re: svn commit: r246380 - projects/cider/usr.bin/make To: Alfred Perlstein Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQkWOHxDXKvQFIX2/V2r0Vka5h9Ok2IaIRpFMi4oZuHi4slhVhEieO/GDuRZdRKzPtPFqJhW Cc: svn-src-projects@freebsd.org, Alfred Perlstein , src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2013 14:01:44 -0000 On 6 February 2013 08:41, Alfred Perlstein wrote: > On 2/5/13 8:40 PM, Eitan Adler wrote: >> >> On 5 February 2013 23:36, Alfred Perlstein wrote: >>> >>> Author: alfred >>> Date: Wed Feb 6 04:36:57 2013 >>> New Revision: 246380 >>> URL: http://svnweb.freebsd.org/changeset/base/246380 >>> >>> Log: >>> Add headers needed to compile on OS X 10.7.5. >> >> Please make sure to annotate that these headers are required on >> !FreeBSD otherwise they may be removed if someone does a "include what >> you use" run. >> >> > Is there an existing way of doing this? > > I'm not sure if I should just do > #ifndef __FreeBSD__ > or something else? This is fine by me, but others may have more clue about what is convention. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams