From nobody Fri Sep 12 11:59:40 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cNXzY73dwz67Msm; Fri, 12 Sep 2025 11:59:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cNXzY3LZPz3d8v; Fri, 12 Sep 2025 11:59:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 58CBxea3005237; Fri, 12 Sep 2025 14:59:43 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 58CBxea3005237 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 58CBxewZ005236; Fri, 12 Sep 2025 14:59:40 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 12 Sep 2025 14:59:40 +0300 From: Konstantin Belousov To: Zhenlei Huang Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 22238759c57d - main - sys/bus.h: Some style(9) fixes Message-ID: References: <202509120456.58C4uwVD027045@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202509120456.58C4uwVD027045@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cNXzY3LZPz3d8v On Fri, Sep 12, 2025 at 04:56:58AM +0000, Zhenlei Huang wrote: > The branch main has been updated by zlei: > > URL: https://cgit.FreeBSD.org/src/commit/?id=22238759c57d942865cf9d1a355a0d04819eb621 > > commit 22238759c57d942865cf9d1a355a0d04819eb621 > Author: Zhenlei Huang > AuthorDate: 2025-09-12 04:55:14 +0000 > Commit: Zhenlei Huang > CommitDate: 2025-09-12 04:55:14 +0000 > > sys/bus.h: Some style(9) fixes > > and whitespace cleanup. > > MFC after: 3 days > --- > sys/sys/bus.h | 38 ++++++++++++++++++++------------------ > 1 file changed, 20 insertions(+), 18 deletions(-) > > diff --git a/sys/sys/bus.h b/sys/sys/bus.h > index dda27f4737b2..e7ce152160f8 100644 > --- a/sys/sys/bus.h > +++ b/sys/sys/bus.h > @@ -78,7 +78,7 @@ typedef enum device_property_type { > * The strings are placed one after the other, separated by NUL characters. > * Fields should be added after the last one and order maintained for compatibility > */ > -#define BUS_USER_BUFFER (3*1024) > +#define BUS_USER_BUFFER (3 * 1024) > struct u_device { > uintptr_t dv_handle; > uintptr_t dv_parent; > @@ -247,8 +247,8 @@ typedef struct devclass *devclass_t; > * and may use regular mutexes. However, it is prohibited from > * sleeping on a sleep queue. > */ > -typedef int driver_filter_t(void*); > -typedef void driver_intr_t(void*); > +typedef int driver_filter_t(void *); > +typedef void driver_intr_t(void *); What are the fixes there, specifically? > > /** > * @brief Interrupt type bits. > @@ -476,18 +476,18 @@ int bus_generic_resume(device_t dev); > int bus_generic_resume_child(device_t dev, device_t child); > int bus_generic_setup_intr(device_t dev, device_t child, > struct resource *irq, int flags, > - driver_filter_t *filter, driver_intr_t *intr, > + driver_filter_t *filter, driver_intr_t *intr, > void *arg, void **cookiep); And there? The continuation indent is completely wrong from the style(9) guide, and the change just kept it, there and everywhere.