From owner-cvs-all@FreeBSD.ORG  Sat Sep 20 12:51:25 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A7F2516A4B3
	for <cvs-all@FreeBSD.org>; Sat, 20 Sep 2003 12:51:25 -0700 (PDT)
Received: from mail26a.sbc-webhosting.com (mail26a.sbc-webhosting.com
	[216.173.237.164])
	by mx1.FreeBSD.org (Postfix) with SMTP id AC42F43FF5
	for <cvs-all@FreeBSD.org>; Sat, 20 Sep 2003 12:51:22 -0700 (PDT)
	(envelope-from alc@imimic.com)
Received: from www.imimic.com (64.143.12.21)4-0615097464;
	Sat, 20 Sep 2003 15:51:05 -0400 (EDT)
Sender: alc@FreeBSD.ORG
Message-ID: <3F6CAFAA.F48E2A12@imimic.com>
Date: Sat, 20 Sep 2003 14:51:06 -0500
From: "Alan L. Cox" <alc@imimic.com>
Organization: iMimic Networking, Inc.
X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i686)
X-Accept-Language: en
MIME-Version: 1.0
To: Marcel Moolenaar <marcel@FreeBSD.org>
References: <200309201927.h8KJRm9e006832@repoman.freebsd.org>
Content-Type: text/plain; charset=x-user-defined
Content-Transfer-Encoding: 7bit
X-Loop-Detect: 1
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/conf files.ia64 src/sys/ia64/ia64 
 pmap.cuma_machdep.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Sep 2003 19:51:25 -0000

Marcel Moolenaar wrote:
> 
> marcel      2003/09/20 12:27:48 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/conf             files.ia64
>     sys/ia64/ia64        pmap.c
>   Added files:
>     sys/ia64/ia64        uma_machdep.c
>   Log:
>   Move uma_small_alloc() and uma_small_free() to uma_machdep.c. These
>   functions reference UMA internals from <vm/uma_int.h>, which makes
>   them highly unwanted in non-UMA specific files.
> 
>   While here, prune the includes in pmap.c and use __FBSDID(). Move
>   the includes above the descriptive comment.
> 
>   The copyright of uma_machdep.c is assigned to the project and can
>   be reassigned to the foundation if and when when such is preferrable.
> 
>   Revision  Changes    Path
>   1.59      +1 -0      src/sys/conf/files.ia64
>   1.123     +22 -77    src/sys/ia64/ia64/pmap.c
>   1.1       +82 -0     src/sys/ia64/ia64/uma_machdep.c (new)

An observation ... we now have three different locations, on four
different architectures, for these functions.  I definitely agree that
pmap.c is the wrong place because these functions have nothing to do
with page table and/or TLB management.  Long ago, I encouraged Jake to
start a trend for the better by placing the sparc64 implementations in
vm_machdep.c.  Whether it's uma_machdep.c or vm_machdep.c doesn't matter
much to me, only that we arrive at a consensus on which it is.  I would
observe the similarities to the new, optimized amd64 and ia64
sf_buf_alloc() implementations as an argument for vm_machdep.c.

In any case, I'll volunteer to update amd64 to match the new consensus.

Regards,
Alan