From owner-cvs-all Sat Mar 15 16:40:48 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 367EC37B401; Sat, 15 Mar 2003 16:40:47 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56F2943F93; Sat, 15 Mar 2003 16:40:46 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.8/8.12.3) with ESMTP id h2G0eiA7010112; Sat, 15 Mar 2003 17:40:45 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sat, 15 Mar 2003 17:38:49 -0700 (MST) Message-Id: <20030315.173849.103229416.imp@bsdimp.com> To: des@ofug.org Cc: mdodd@FreeBSD.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_iso88025subr.c From: "M. Warner Losh" In-Reply-To: References: <200303152237.h2FMbCCZ012310@repoman.freebsd.org> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: des@ofug.org (Dag-Erling Sm=F8rgrav) writes: : "Matthew N. Dodd" writes: : > Log: : > - Style(9) changes. : > - Remove unneeded assignment. : > - Increment if_oerrors as per if_fddisubr.c. : > - Wrap ISO code with conditional. : = : This was the 14th consecutive commit to the same file in under 6 : hours. I think that's some kind of record... Next time, please test= : before committing. I don't see Matt's changes as a lack of testing. he's doing what people have always done. I did it many times in the oldcard code when I wanted to make each change separately on purpose. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message