From nobody Sun Oct 10 22:45:53 2021
X-Original-To: python@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3998817F552F;
Sun, 10 Oct 2021 22:46:06 +0000 (UTC)
(envelope-from koobs.freebsd@gmail.com)
Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636])
(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
client-signature RSA-PSS (2048 bits) client-digest SHA256)
(Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 4HSH8Y1zHhz3KbX;
Sun, 10 Oct 2021 22:46:05 +0000 (UTC)
(envelope-from koobs.freebsd@gmail.com)
Received: by mail-pl1-x636.google.com with SMTP id y1so9928049plk.10;
Sun, 10 Oct 2021 15:46:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=sender:message-id:date:mime-version:user-agent:reply-to:subject
:content-language:to:references:cc:from:in-reply-to
:content-transfer-encoding;
bh=97Oq15Zf8l5exLCdyxiWrLw8YbFW0lGiB9EnXB8h9ME=;
b=E7KF4RXfidkV/0faPmYtTVst345cptrc6oQBwh8Ihq6jv5rdJuHkA15WyoWZFhgqgT
+lzrzmCuOyoAFUtzRb2nV9QmaFrxdHHRKmhTzHJS18bU4MwOq60KzWXwLzvagb4VV/dI
JbZbjlsz8E/sKY26osTYufkTyva2/PwURK7kd9yeQ4HRhQ7qrSpr4MhpELc3FNsLpwjU
DEq9JgYtRryWbTPfiiEhxhcu6cuk1/BgedCalsfdTxbVUtZfjl1a3Pu4l5bc3TGWKNe6
hFEheJ+judnX+nbpgDTtVK6yT/Vz+epG/Oi7tfVUMAaW7QAeU+GYk8xo/8NQrqQpO8+P
fzrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:sender:message-id:date:mime-version:user-agent
:reply-to:subject:content-language:to:references:cc:from:in-reply-to
:content-transfer-encoding;
bh=97Oq15Zf8l5exLCdyxiWrLw8YbFW0lGiB9EnXB8h9ME=;
b=a8uox9VqHum/kh5gA/HZIWy/lWu0rRXKJeMFcLSomzlp5pxipnOQ3T78+Muac8zoTg
BVkKQyDXQhWj8Zfi15714WrjS6s8XW6diH4gQuY1bWRn1OCwThlhyJuUyHySGHTAPtRA
TwLObfkySecioO6GTEuOtbM6xjEsp42AvvxNrq6lglshm1AS41jzPNX6PikdOcAvrrzy
eQMcm3jvUHUdnzOzEVswISASm3R2mDvz+PxFqZMQ7mg785VNDfCsfIcHSO/AeEG50Mhs
7iNuCZBArR0fyiEmRwfCiQNAij+R7FKgmWzEFBL06FlA+ac4E2mA/+38ZfOxL+sr7Fam
jiWA==
X-Gm-Message-State: AOAM530ihjfvQcWYRnXeZ++cQJvsfh0Ad0jdT1nq9OEoEcGCfWL+kxPM
MBqgAzrnwcNUTyePBWTDfoJ8yjyJRis=
X-Google-Smtp-Source: ABdhPJxLnsYQp0pXuN0CwfMI+RzcmglRMajR+DY/wV0ee+DWQIpcWEW8eI/Mzk99cb9Qgfmg3MCE2g==
X-Received: by 2002:a17:902:e801:b0:13f:255:9db5 with SMTP id u1-20020a170902e80100b0013f02559db5mr21136554plg.23.1633905958043;
Sun, 10 Oct 2021 15:45:58 -0700 (PDT)
Received: from ?IPV6:2403:5800:7500:3601:4828:e6b4:b06a:61e0? (2403-5800-7500-3601-4828-e6b4-b06a-61e0.ip6.aussiebb.net. [2403:5800:7500:3601:4828:e6b4:b06a:61e0])
by smtp.gmail.com with ESMTPSA id o2sm5958679pgc.47.2021.10.10.15.45.55
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Sun, 10 Oct 2021 15:45:57 -0700 (PDT)
Message-ID: <4838ed6d-a2c2-fc69-02ff-0d46a36b0efc@FreeBSD.org>
Date: Mon, 11 Oct 2021 09:45:53 +1100
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-python
List-Help: <mailto:python+help@freebsd.org>
List-Post: <mailto:python@freebsd.org>
List-Subscribe: <mailto:python+subscribe@freebsd.org>
List-Unsubscribe: <mailto:python+unsubscribe@freebsd.org>
Sender: owner-freebsd-python@freebsd.org
X-BeenThere: freebsd-python@freebsd.org
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:95.0) Gecko/20100101
Thunderbird/95.0a1
Reply-To: koobs@FreeBSD.org
Subject: Re: git: 8332894f1a6d - main - devel/py-os-brick: Fix python
dependency version.
Content-Language: en-US
To: Mikael Urankar <mikael@FreeBSD.org>, ports-committers@FreeBSD.org,
dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
References: <202110071150.197BohT1035282@gitrepo.freebsd.org>
Cc: python <python@FreeBSD.org>
From: Kubilay Kocak <koobs@FreeBSD.org>
In-Reply-To: <202110071150.197BohT1035282@gitrepo.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4HSH8Y1zHhz3KbX
X-Spamd-Bar: /
Authentication-Results: mx1.freebsd.org;
dkim=pass header.d=gmail.com header.s=20210112 header.b=E7KF4RXf;
dmarc=none;
spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::636 as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com
X-Spamd-Result: default: False [-0.82 / 15.00];
HAS_REPLYTO(0.00)[koobs@FreeBSD.org];
RCVD_VIA_SMTP_AUTH(0.00)[];
TO_DN_SOME(0.00)[];
R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36];
REPLYTO_ADDR_EQ_FROM(0.00)[];
RCPT_COUNT_FIVE(0.00)[5];
RCVD_COUNT_THREE(0.00)[3];
DKIM_TRACE(0.00)[gmail.com:+];
FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com];
MIME_TRACE(0.00)[0:+];
FREEMAIL_ENVFROM(0.00)[gmail.com];
ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US];
MID_RHS_MATCH_FROM(0.00)[];
TAGGED_FROM(0.00)[];
DWL_DNSWL_NONE(0.00)[gmail.com:dkim];
FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com];
ARC_NA(0.00)[];
R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112];
NEURAL_HAM_MEDIUM(-0.06)[-0.056];
FROM_HAS_DN(0.00)[];
TO_MATCH_ENVRCPT_ALL(0.00)[];
NEURAL_HAM_LONG(-0.99)[-0.991];
MIME_GOOD(-0.10)[text/plain];
DMARC_NA(0.00)[FreeBSD.org];
NEURAL_SPAM_SHORT(0.43)[0.427];
RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::636:from];
RCVD_TLS_ALL(0.00)[]
X-ThisMailContainsUnwantedMimeParts: N
On 7/10/2021 10:50 pm, Mikael Urankar wrote:
> The branch main has been updated by mikael:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=8332894f1a6d0c128476419235018ca4051b6b1d
>
> commit 8332894f1a6d0c128476419235018ca4051b6b1d
> Author: Mikael Urankar <mikael@FreeBSD.org>
> AuthorDate: 2021-10-07 11:47:01 +0000
> Commit: Mikael Urankar <mikael@FreeBSD.org>
> CommitDate: 2021-10-07 11:50:40 +0000
>
> devel/py-os-brick: Fix python dependency version.
>
> py-pbr is at version 5.5.0.
>
> Build error:
> py38-os-brick-5.0.0 depends on package: py38-pbr>=5.5.1 - not found
>
> Approved by: portmgr (build fix blanket)
> ---
> devel/py-os-brick/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devel/py-os-brick/Makefile b/devel/py-os-brick/Makefile
> index 48565419ce94..90b16f4cc483 100644
> --- a/devel/py-os-brick/Makefile
> +++ b/devel/py-os-brick/Makefile
> @@ -23,7 +23,7 @@ RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}eventlet>=0.30.1:net/py-eventlet@${PY_FLAVOR
> ${PYTHON_PKGNAMEPREFIX}oslo.serialization>=4.1.0:devel/py-oslo.serialization@${PY_FLAVOR} \
> ${PYTHON_PKGNAMEPREFIX}oslo.service>=2.5.0:devel/py-oslo.service@${PY_FLAVOR} \
> ${PYTHON_PKGNAMEPREFIX}oslo.utils>=4.8.0:devel/py-oslo.utils@${PY_FLAVOR} \
> - ${PYTHON_PKGNAMEPREFIX}pbr>=5.5.1:devel/py-pbr@${PY_FLAVOR} \
> + ${PYTHON_PKGNAMEPREFIX}pbr>=5.5.0:devel/py-pbr@${PY_FLAVOR} \
> ${PYTHON_PKGNAMEPREFIX}requests>=2.25.1:www/py-requests@${PY_FLAVOR} \
> ${PYTHON_PKGNAMEPREFIX}tenacity>=6.3.1:devel/py-tenacity@${PY_FLAVOR}
>
>
Note that changing *_DEPENDS versions without actually patching what
Python packages actually specify and check at runtime (setup.py, or
requirements.txt *if* those are used in setup.py's) wont fix anything,
and will remain broken at runtime.
In this case os-brick's setup.py specifies:
setup_requires=['pbr>=2.0.0'],
And it looks like this port is matching RUN_DEPENDS to requirements.txt,
which specifies >=5.5.1, but requirements.txt is not sourced or used by
setuptools (or setup.py)
If os-brick actually *requires* 5.5.1 (uses something available only in
5.5.1), then this package's RUN_DEPENDS is (was) correct and the
setup.py should reflect that (not >=2.0.0).
If it doesn't require something only in 5.5.1, RUN_DEPENDS should match
what is in setup.py, or whatever the actual minimum dependency
requirement is.