From nobody Thu May 22 14:39:56 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b39tN6qJsz5wlRS; Thu, 22 May 2025 14:39:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b39tN6Cpfz49xW; Thu, 22 May 2025 14:39:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747924796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MlSEcGWGLQvSx3zHzu4fRpANuM253uAL1R9PYMOf2xM=; b=ixbuVa494rzIqwWRJ166FSZy63fmzW8/jjMIkgVR/NcmV5WRSIcx2Nchny8esW+U8mnpVD Q43BofxwNX+rEuStVnN2aTxichZugb6jN/LIvd6yOxhtij3k1XyUfBwfO2KvopQ/QK6oqS Amx9HLK3bWtJm1qB9JEgoMoZ/gP7riPxkZSZFYkdA5w1IGeBRThwN8QYrjmrMAWziXbyYC //9OnQI9d5dNs0nk/lHFrzytFAmMoQTje4UC4GCSBt7UDu1VhByR95nW0NwoPxC5w5i7Zq FK0v5+Bz0F21UReOUGtwjNLAqMqfvDMNWoAYqPiiU83uI7LseRB4YiK3xbRX6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747924796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MlSEcGWGLQvSx3zHzu4fRpANuM253uAL1R9PYMOf2xM=; b=dT6IrzGVlury1CZVv68DGSA6c3mGSfF3W93tFZudPHmstJT1HzLPh+dtzC5WTibb3loaQW xWwCuoJ4kq4rTz/keQQLeNZn4pODrlFUBYPNQC1TT09TcRFbiXI7AVJ6+gegAlZM9XXjUX BPFu1XjnXBSaPAUf0o5htbQFQoLhcN+GGvp6W0y9hGmr/GhJvC9dZxzZ7P0DtutTA4SAZh hEW4tl96GVt5vlgd2l1tNEb3Gi/fFa/Sm0VskATL1PGhQsbMT0rZBz9yjjMX70VU2LMlVK laoG/vPEdBqdpa7jciBtw1orYhOsLwJhwV7oeNT4HpjB/G7FLKnnm8g98X0Nvw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747924796; a=rsa-sha256; cv=none; b=OUoyTfKvJD79ZBFfGHN6rASSrN2VYr9vQ6u0cSWmtTt6xHj7tK7svTuUnULszd62NZA1zW cM95kIP9CuVBMWqWSWaOnfEwz1cI4FoA5mzCK7d12u+AyLcOWqD4ZNJvlt55074jHq71m9 tpKcPZdnULJS1US+uRO+86RB5tCqt4bthlhwkwU1WBsbPLcNLPD5s5gJcXhLfSpaLTDmf4 fjFNxfhhJ3E83SUg8MnKnsQF1TeLbOIBimSaFd2lJcsDUMfCtA1HlobOw+jSglKxwKMMa9 /WYgSK5HhY47nEUPYfuoNWWrZxYeGfwdirdrfQnUuH+Tl3My9QqfqdZFC0hzGA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b39tN5DG7z8B7; Thu, 22 May 2025 14:39:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54MEduMt016658; Thu, 22 May 2025 14:39:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54MEduaR016655; Thu, 22 May 2025 14:39:56 GMT (envelope-from git) Date: Thu, 22 May 2025 14:39:56 GMT Message-Id: <202505221439.54MEduaR016655@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 903d29469ecb - main - vnode_if: Remove some branching around SDT probes in VOP wrappers List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 903d29469ecb4212c2eed382dc0c5d4536d413b0 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=903d29469ecb4212c2eed382dc0c5d4536d413b0 commit 903d29469ecb4212c2eed382dc0c5d4536d413b0 Author: Mark Johnston AuthorDate: 2025-05-22 14:37:49 +0000 Commit: Mark Johnston CommitDate: 2025-05-22 14:37:49 +0000 vnode_if: Remove some branching around SDT probes in VOP wrappers Now that SDT is implemented using hot-patching, SDT_PROBE* no longer introduces a branch instruction, so the SDT_PROBES_ENABLED() check in each VOP_*_APV() is not really worth preserving. Reviewed by: olce, kib Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D50423 --- sys/tools/vnode_if.awk | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/sys/tools/vnode_if.awk b/sys/tools/vnode_if.awk index 2326d0e28956..d23c2af9bd9a 100644 --- a/sys/tools/vnode_if.awk +++ b/sys/tools/vnode_if.awk @@ -401,13 +401,9 @@ while ((getline < srcfile) > 0) { add_pre(name); for (i = 0; i < numargs; ++i) add_debug_code(name, args[i], "Entry", "\t"); - printc("\tif (!SDT_PROBES_ENABLED()) {"); - printc("\t\trc = vop->"name"(a);") - printc("\t} else {") - printc("\t\tSDT_PROBE2(vfs, vop, " name ", entry, a->a_" args[0] ", a);"); - printc("\t\trc = vop->"name"(a);") - printc("\t\tSDT_PROBE3(vfs, vop, " name ", return, a->a_" args[0] ", a, rc);"); - printc("\t}") + printc("\tSDT_PROBE2(vfs, vop, " name ", entry, a->a_" args[0] ", a);"); + printc("\trc = vop->"name"(a);") + printc("\tSDT_PROBE3(vfs, vop, " name ", return, a->a_" args[0] ", a, rc);"); printc("\tif (rc == 0) {"); for (i = 0; i < numargs; ++i) add_debug_code(name, args[i], "OK", "\t\t");