From nobody Mon Apr 17 08:57:32 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q0LY741f8z45bS7 for ; Mon, 17 Apr 2023 08:57:47 +0000 (UTC) (envelope-from fbl@aoek.com) Received: from mail.yourbox.net (mail.yourbox.net [IPv6:2001:41d0:1:767d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.yourbox.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q0LY717TYz4NMp; Mon, 17 Apr 2023 08:57:46 +0000 (UTC) (envelope-from fbl@aoek.com) Authentication-Results: mx1.freebsd.org; none Received: from mail.yourbox.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail.yourbox.net (8.17.1/8.17.1) with ESMTP id 33H8vbuU054600; Mon, 17 Apr 2023 10:57:37 +0200 (CEST) (envelope-from fbl@aoek.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aoek.com; s=mailbox; t=1681721857; bh=0caX5SZ9WdCAe47hdPEa0B9p4WQRuIk3dMmz5TLliyY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Jzb0GZnfLy4Lxi7deWQNfhGhqHoRMB0rsefFh+4eA1pTDCRhj9UUJ0r4jWnGKNbZo A2sLYlXH2AEjKDNS++9KJ67HE9IWbtMjLQYrHwVUY6orzdtdi2C2K5POicPILilJ42 7HoO3XkjDCX6sjHxJ7a3jRslvWKNv2AsilQtx+yxzdeckhgfuK6hAIbZXr+VzOLAeK 4NFJqj5r3i7oeHFc7npiq5knZ44WBN52Cw+LtVBZknVLS0ic7d24rdd2dINsb1oK/y F1T6WPYnRlsULcTFs4zTb5yjh2gBAFWppSMP/1uNEMVcKUNtKSUkv4fzefTCc38kr5 W3kW6OBHQYSlg== List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 17 Apr 2023 10:57:32 +0200 From: =?UTF-8?Q?Jos=C3=A9_P=C3=A9rez?= To: Pawel Jakub Dawidek Cc: freebsd-current@freebsd.org Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 In-Reply-To: <80ea8a67-9b64-c723-6d97-21cfa127ae43@dawidek.net> References: <20230413071032.18BFF31F@slippy.cwsent.com> <20230413063321.60344b1f@cschubert.com> <20230413135635.6B62F354@slippy.cwsent.com> <319a267e-3f76-3647-954a-02178c260cea@dawidek.net> <441db213-2abb-b37e-e5b3-481ed3e00f96@dawidek.net> <5ce72375-90db-6d30-9f3b-a741c320b1bf@freebsd.org> <99382FF7-765C-455F-A082-C47DB4D5E2C1@yahoo.com> <32cad878-726c-4562-0971-20d5049c28ad@freebsd.org> <20230415115452.08911bb7@thor.intern.walstatt.dynvpn.de> <20230415143625.99388387@slippy.cwsent.com> <20230415175218.777d0a97@thor.intern.walstatt.dynvpn.de> <6792aded-6e2e-a118-259d-0df0f80c361c@smeets.xyz> <80ea8a67-9b64-c723-6d97-21cfa127ae43@dawidek.net> Message-ID: X-Sender: fbl@aoek.com User-Agent: Roundcube Webmail/1.2.0 X-Rspamd-Queue-Id: 4Q0LY717TYz4NMp X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Hi Pawel, thank you for the patch. Can you please elaborate a little more? Did you run any tests? Is it safe to use your patch to access pools with feature@block_cloning active? Is it possible to build a kernel from such a pool? Asking for others: is this fixing any corrupted data? Thank you. BR, El 2023-04-17 06:35, Pawel Jakub Dawidek escribió: > On 4/16/23 01:07, Florian Smeets wrote: >> On the pool that has block_cloning enabled I see the above insta panic >> when poudriere starts building. I found a workaround though: >> >> --- /usr/local/share/poudriere/include/fs.sh.orig    2023-04-15 >> 18:03:50.090823000 +0200 >> +++ /usr/local/share/poudriere/include/fs.sh    2023-04-15 >> 18:04:04.144736000 +0200 >> @@ -295,7 +295,6 @@ >>          fi >> >>          zfs clone -o mountpoint=${mnt} \ >> -            -o sync=disabled \ >>              -o atime=off \ >>              -o compression=off \ >>              ${fs}@${snap} \ >> >> With this workaround I was able to build thousands of packages without >> panics or failures due to data corruption. > > Thank you, Florian, that was very helpful! > > This should fix the problem: > > https://github.com/openzfs/zfs/pull/14758 -- José Pérez