Date: Mon, 17 Apr 2023 10:57:32 +0200 From: =?UTF-8?Q?Jos=C3=A9_P=C3=A9rez?= <fbl@aoek.com> To: Pawel Jakub Dawidek <pjd@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 Message-ID: <b3d8b8f7a35312b1211b76b111c01242@mail.yourbox.net> In-Reply-To: <80ea8a67-9b64-c723-6d97-21cfa127ae43@dawidek.net> References: <20230413071032.18BFF31F@slippy.cwsent.com> <D0D9BD06-C321-454C-A038-C55C63E0DD6B@dawidek.net> <20230413063321.60344b1f@cschubert.com> <CAGudoHG3rCx93gyJTmzTBnSe4fQ9=m4mBESWbKVWtAGRxen_4w@mail.gmail.com> <20230413135635.6B62F354@slippy.cwsent.com> <c41f9ed6-e557-9255-5a46-1a22d4b32d66@dawidek.net> <319a267e-3f76-3647-954a-02178c260cea@dawidek.net> <b60807e9-f393-6e6d-3336-042652ddd03c@freebsd.org> <441db213-2abb-b37e-e5b3-481ed3e00f96@dawidek.net> <5ce72375-90db-6d30-9f3b-a741c320b1bf@freebsd.org> <99382FF7-765C-455F-A082-C47DB4D5E2C1@yahoo.com> <32cad878-726c-4562-0971-20d5049c28ad@freebsd.org> <ABC9F3DB-289E-455E-AF43-B3C13525CB2C@yahoo.com> <20230415115452.08911bb7@thor.intern.walstatt.dynvpn.de> <20230415143625.99388387@slippy.cwsent.com> <20230415175218.777d0a97@thor.intern.walstatt.dynvpn.de> <6792aded-6e2e-a118-259d-0df0f80c361c@smeets.xyz> <80ea8a67-9b64-c723-6d97-21cfa127ae43@dawidek.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Pawel,
thank you for the patch.
Can you please elaborate a little more?
Did you run any tests? Is it safe to use your patch to access pools with
feature@block_cloning active? Is it possible to build a kernel from such
a pool?
Asking for others: is this fixing any corrupted data?
Thank you.
BR,
El 2023-04-17 06:35, Pawel Jakub Dawidek escribió:
> On 4/16/23 01:07, Florian Smeets wrote:
>> On the pool that has block_cloning enabled I see the above insta panic
>> when poudriere starts building. I found a workaround though:
>>
>> --- /usr/local/share/poudriere/include/fs.sh.orig 2023-04-15
>> 18:03:50.090823000 +0200
>> +++ /usr/local/share/poudriere/include/fs.sh 2023-04-15
>> 18:04:04.144736000 +0200
>> @@ -295,7 +295,6 @@
>> fi
>>
>> zfs clone -o mountpoint=${mnt} \
>> - -o sync=disabled \
>> -o atime=off \
>> -o compression=off \
>> ${fs}@${snap} \
>>
>> With this workaround I was able to build thousands of packages without
>> panics or failures due to data corruption.
>
> Thank you, Florian, that was very helpful!
>
> This should fix the problem:
>
> https://github.com/openzfs/zfs/pull/14758
--
José Pérez
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b3d8b8f7a35312b1211b76b111c01242>