From owner-freebsd-hackers@FreeBSD.ORG  Mon Jul 12 07:29:05 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EB97F106567A
	for <hackers@freebsd.org>; Mon, 12 Jul 2010 07:29:05 +0000 (UTC)
	(envelope-from yanegomi@gmail.com)
Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com
	[209.85.214.182])
	by mx1.freebsd.org (Postfix) with ESMTP id B8C588FC1C
	for <hackers@freebsd.org>; Mon, 12 Jul 2010 07:29:05 +0000 (UTC)
Received: by iwn35 with SMTP id 35so5428670iwn.13
	for <hackers@freebsd.org>; Mon, 12 Jul 2010 00:29:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:received:date:message-id
	:subject:from:to:content-type;
	bh=ydWb+TUNANRTI4Mx9uyBt0Hzf1fDJ4atUj3xadnqxcs=;
	b=qg8GL86WTnHxpeUXupoHPlyrQIfn7ZtCF6K6VHFhFCsGUO6Q2cq2uhEwYFIeedVy1X
	JK8ZyKxM8bnegO+5nVsxyHi2WAZD5kiH8SUz+8xPqffUqbqGOqTIKkPp4vC2NReekCsF
	Glgsyn1SOdlCAGnS9lTVxGlaZZUJrdf0Ccb24=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:date:message-id:subject:from:to:content-type;
	b=mKXfTmYhQ8ZFm3+r9gGM5Q+7tDWjqGYTmMKJW6Mmi/2EEsze57ci+3jVFYIfG69hR3
	8GTl52i8pHBKYp4ZjE+Rfr08W2r2mgFu47lWg3UR5qJMygaKfcnfEQC1U+lLRepsO2HF
	gN5/vQS8DYM9EBM5co1FCaTi9mHkeE+6M7QWs=
MIME-Version: 1.0
Received: by 10.231.191.138 with SMTP id dm10mr2041539ibb.126.1278919744810; 
	Mon, 12 Jul 2010 00:29:04 -0700 (PDT)
Received: by 10.231.182.74 with HTTP; Mon, 12 Jul 2010 00:29:04 -0700 (PDT)
Date: Mon, 12 Jul 2010 00:29:04 -0700
Message-ID: <AANLkTikqOWgfz6oDnJD09rZtMfLnLb3k-bLypHnqOo4Y@mail.gmail.com>
From: Garrett Cooper <yanegomi@gmail.com>
To: hackers@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1
Cc: 
Subject: [PATCH] Use _SIG_VALID macro in ddb/db_command.c
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Jul 2010 07:29:06 -0000

Spotted this really minor item that I figured could be converted over
to _SIG_VALID in ddb:

Index: ddb/db_command.c
===================================================================
--- ddb/db_command.c	(revision 206173)
+++ ddb/db_command.c	(working copy)
@@ -633,7 +633,7 @@
 	if (!db_expression(&pid))
 		DB_ERROR(("Missing process ID\n"));
 	db_skip_to_eol();
-	if (sig < 1 || sig > _SIG_MAXSIG)
+	if (!_SIG_VALID(sig))
 		DB_ERROR(("Signal number out of range\n"));

 	/*

considering that the above range and _SIG_VALID are complementing checks.

Thanks,
-Garrett