From nobody Wed Feb 5 21:02:59 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YpCPH4rtjz5mP4y; Wed, 05 Feb 2025 21:02:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YpCPH47HNz3Xrc; Wed, 05 Feb 2025 21:02:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738789379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FPuhQoogiHzTU+VRtsraIGSaPy3WAGNsXm0+DncFPi0=; b=r5gooklk+0w1fVUz1VSvVl97Kf4rrBMhvcxsLzisXCx2dNJ6WYVis/NRLuMgKl/M2+WRBe HcIt9aLMoh3gYqRfj2gLEs7qRh8r6xaYNdG6gih9ncvFcb3s0HTS/9PcwL7E4nZY+mkCkk lRvAjVvfMfchQ5K1sKJYTihz+tpJoWJ3v2YpDTyx0bYlRXfVhZo6YwwWlFiq9KZaLZIUdW QI3zCMIBVlzxhvmNENy+fXmZMapcLK6YbFh6hr6wtkvpuhCtLyV66Cz/ZtVzccvNQs/Dgn 0833lMgjh7wkmprLijDBEMfJt8nhVqJws+cro8jJWByspAX7UM3diC53O4n65g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738789379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FPuhQoogiHzTU+VRtsraIGSaPy3WAGNsXm0+DncFPi0=; b=D+pGYD+PRx2Tuu1a+IMvqcsDFCxVvoFEtwyqF9/bB0pwhT9/fvOQuEN3wXsqxhmFV7bJw6 JYfAAuArdwKRVOUto6bNI5k02oC9bYeKN0yQm5WEu4XGqmFZTx7llVT5u1hWix2EUEPyST HOP8QVJ3RE08gbylWi+ezPuBtkE+lZiAL5x+lNTswvGNGuDqdsF3nGCGVGRzF7m6TUKhgR YltlJqjw8O7Xo+EdDa2NOOr/S/BSTduvFKIUZ1ceSd24NXWeMixdGPJ/olUpHqpUXKX797 ZkP35RJdv2pFdGlSzauFeuIVamGOpC61t+qd0ixMvtvESQadYxQJiCV0lX/pOw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738789379; a=rsa-sha256; cv=none; b=Y5glq/1a4+jXltA7UsGy6EhR0XS5nT4uK3/9eogG/v+vvNmeQn/JOKosXpu9pHqUsbLStz StwIRxXpFSLop0dVzUI6ORu8JPvWHZZmmJ9+i6jg60zzlZYkKgpIwpZzq01TUq0tOskevI Nv5ARg+KsVPNg07kdqdkHU0wy5/8Y/BANHVAfJn45JtkA/zcZzMeVWzp+agETZBnxEcCGX PrgJQQSUZbWnQVD+Oxxg9Va7egfcd58pyRhFaUEviUgssnaM9tCZLoKCn259Sfyw45ESuy 9ishACd5A7ACUqLt/Tm8DrRN4o8U8QvRbJ1OgGdjSN7mlCf4hf/pzAOvKOCdWg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YpCPH3kYPz17B7; Wed, 05 Feb 2025 21:02:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 515L2xfM023200; Wed, 5 Feb 2025 21:02:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 515L2x6A023197; Wed, 5 Feb 2025 21:02:59 GMT (envelope-from git) Date: Wed, 5 Feb 2025 21:02:59 GMT Message-Id: <202502052102.515L2x6A023197@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 3cf7769f1f18 - stable/13 - TCP RACK: don't log an uninitialized value List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 3cf7769f1f180ac310c34e6389ee645c5928d808 Auto-Submitted: auto-generated The branch stable/13 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=3cf7769f1f180ac310c34e6389ee645c5928d808 commit 3cf7769f1f180ac310c34e6389ee645c5928d808 Author: Michael Tuexen AuthorDate: 2025-01-08 22:15:54 +0000 Commit: Michael Tuexen CommitDate: 2025-02-05 20:48:07 +0000 TCP RACK: don't log an uninitialized value reduce is uninitialized, if the code path for logging is reached via goto old_method;. Reviewed by: rrs, Peter Lei CID: 1557359 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48346 (cherry picked from commit 4c89d59e0cdac4d83fb5841aefae9214545b2273) --- sys/netinet/tcp_stacks/rack.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index b4c4a6ed85dc..093baca4cf0a 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -14419,7 +14419,7 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str * the peer to have a gap in data sending. */ uint32_t srtt, cwnd, tr_perms = 0; - int32_t reduce = 0; + int32_t reduce; old_method: /* @@ -14456,7 +14456,8 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str slot -= reduce; } else slot = 0; - } + } else + reduce = 0; slot *= HPTS_USEC_IN_MSEC; if (rack->rc_pace_to_cwnd) { uint64_t rate_wanted = 0;