From owner-svn-src-all@FreeBSD.ORG Wed May 27 11:17:49 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D700C106566C; Wed, 27 May 2009 11:17:49 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 59C0C8FC22; Wed, 27 May 2009 11:17:49 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1M9H8l-000Hrk-QO; Wed, 27 May 2009 14:17:47 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n4RBHfuL040550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 27 May 2009 14:17:42 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n4RBHfut050612; Wed, 27 May 2009 14:17:41 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n4RBHfR1050611; Wed, 27 May 2009 14:17:41 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 27 May 2009 14:17:41 +0300 From: Kostik Belousov To: Stacey Son Message-ID: <20090527111741.GH1927@deviant.kiev.zoral.com.ua> References: <200905262139.n4QLd9pI074530@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RzyRI1FIOvhQ4MGO" Content-Disposition: inline In-Reply-To: <200905262139.n4QLd9pI074530@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.1 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1M9H8l-000Hrk-QO 20d0fe7fe45db0791fcb4a7a4a63b780 X-Terabit: YES Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r192859 - in head: share/man/man4 sys/conf sys/dev/ksyms sys/kern sys/modules sys/modules/ksyms sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2009 11:17:50 -0000 --RzyRI1FIOvhQ4MGO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 26, 2009 at 09:39:09PM +0000, Stacey Son wrote: > Author: sson > Date: Tue May 26 21:39:09 2009 > New Revision: 192859 > URL: http://svn.freebsd.org/changeset/base/192859 >=20 > Log: > Add the ksyms(4) pseudo driver. The ksyms driver allows a process to > get a quick snapshot of the kernel's symbol table including the symbols > from any loaded modules (the symbols are all merged into one symbol > table). Unlike like other implementations, this ksyms driver maps > memory in the process memory space to store the snapshot at the time > /dev/ksyms is opened. It also checks to see if the process has already > a snapshot open and won't allow it to open /dev/ksyms it again until it > closes first. This prevents kernel and process memory from being > exhausted. Note that /dev/ksyms is used by the lockstat(1) command. > =20 > Reviewed by: gallatin kib (freebsd-arch) > Approved by: gnn (mentor) What is the reason to have ksyms_unmap() ? Why do you think that checking for the present mapping of the freed region is neccessary ? --RzyRI1FIOvhQ4MGO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkodIVUACgkQC3+MBN1Mb4itswCfZeXrSd7daKZO+83GSb240R+l jlYAoO8Qm5k3Iaz6qI7OLKjj5u7OqFPW =oLsD -----END PGP SIGNATURE----- --RzyRI1FIOvhQ4MGO--