From owner-svn-src-all@FreeBSD.ORG Wed Mar 24 19:21:26 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CF3581065673; Wed, 24 Mar 2010 19:21:26 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id BF0238FC1E; Wed, 24 Mar 2010 19:21:26 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o2OJLQ3D090741; Wed, 24 Mar 2010 19:21:26 GMT (envelope-from bz@svn.freebsd.org) Received: (from bz@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o2OJLQTC090739; Wed, 24 Mar 2010 19:21:26 GMT (envelope-from bz@svn.freebsd.org) Message-Id: <201003241921.o2OJLQTC090739@svn.freebsd.org> From: "Bjoern A. Zeeb" Date: Wed, 24 Mar 2010 19:21:26 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r205626 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2010 19:21:26 -0000 Author: bz Date: Wed Mar 24 19:21:26 2010 New Revision: 205626 URL: http://svn.freebsd.org/changeset/base/205626 Log: Print the pointer to the lock with the panic message. The previous panic: rw lock not unlocked was not really helpful for debugging. Now one can at least call show lock form ddb to learn more about the lock. MFC after: 3 days Modified: head/sys/kern/kern_rwlock.c Modified: head/sys/kern/kern_rwlock.c ============================================================================== --- head/sys/kern/kern_rwlock.c Wed Mar 24 19:20:49 2010 (r205625) +++ head/sys/kern/kern_rwlock.c Wed Mar 24 19:21:26 2010 (r205626) @@ -199,8 +199,8 @@ void rw_destroy(struct rwlock *rw) { - KASSERT(rw->rw_lock == RW_UNLOCKED, ("rw lock not unlocked")); - KASSERT(rw->rw_recurse == 0, ("rw lock still recursed")); + KASSERT(rw->rw_lock == RW_UNLOCKED, ("rw lock %p not unlocked", rw)); + KASSERT(rw->rw_recurse == 0, ("rw lock %p still recursed", rw)); rw->rw_lock = RW_DESTROYED; lock_destroy(&rw->lock_object); }