From owner-svn-src-all@FreeBSD.ORG  Wed Jan 18 06:19:49 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4442B1065678;
	Wed, 18 Jan 2012 06:19:49 +0000 (UTC) (envelope-from ache@vniz.net)
Received: from vniz.net (vniz.net [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id AD4388FC12;
	Wed, 18 Jan 2012 06:19:48 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by vniz.net (8.14.5/8.14.5) with ESMTP id q0I6JkKV081183;
	Wed, 18 Jan 2012 10:19:47 +0400 (MSK) (envelope-from ache@vniz.net)
Received: (from ache@localhost)
	by localhost (8.14.5/8.14.5/Submit) id q0I6JkRI081182;
	Wed, 18 Jan 2012 10:19:46 +0400 (MSK) (envelope-from ache)
Date: Wed, 18 Jan 2012 10:19:45 +0400
From: Andrey Chernov <ache@FreeBSD.ORG>
To: David Schultz <das@FreeBSD.ORG>
Message-ID: <20120118061943.GA80874@vniz.net>
Mail-Followup-To: Andrey Chernov <ache@freebsd.org>,
	David Schultz <das@FreeBSD.ORG>, src-committers@FreeBSD.ORG,
	svn-src-all@FreeBSD.ORG, svn-src-head@FreeBSD.ORG
References: <201201162018.q0GKIADK050161@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201201162018.q0GKIADK050161@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG,
	src-committers@FreeBSD.ORG
Subject: Re: svn commit: r230230 - head/sys/dev/random
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Jan 2012 06:19:49 -0000

On Mon, Jan 16, 2012 at 08:18:10PM +0000, David Schultz wrote:
> Author: das
> Date: Mon Jan 16 20:18:10 2012
> New Revision: 230230
> URL: http://svn.freebsd.org/changeset/base/230230
> 
> Log:
>   Generate a warning if the kernel's arc4random() is seeded with bogus entropy.

While you are here, could you review/commit my patch to fix bad 31bit
arc4rand() seeding, please?

--- yarrow.c.bak	2011-09-26 07:35:48.000000000 +0400
+++ yarrow.c	2012-01-18 10:13:47.000000000 +0400
@@ -59,6 +59,8 @@ static void reseed(u_int);
 /* The reseed thread mutex */
 struct mtx random_reseed_mtx;
 
+static arc4rand_seeded = 0;
+
 /* Process a single stochastic event off the harvest queue */
 void
 random_process_event(struct harvest *event)
@@ -261,6 +263,11 @@ reseed(u_int fastslow)
 
 	/* Release the reseed mutex */
 	mtx_unlock(&random_reseed_mtx);
+
+	if (!arc4rand_seeded) {
+		arc4rand_seeded = 1;
+		arc4rand(NULL, 0, 1);
+	}
 }
 
 /* Internal function to return processed entropy from the PRNG */

-- 
http://ache.vniz.net/