From owner-freebsd-current@freebsd.org Sat Jun 4 17:38:29 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 332A3B6A461 for ; Sat, 4 Jun 2016 17:38:29 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 1B88012B0; Sat, 4 Jun 2016 17:38:29 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 143A51E76; Sat, 4 Jun 2016 17:38:29 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id B7C5B203DF; Sat, 4 Jun 2016 17:38:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id GQfzghT1BbpH; Sat, 4 Jun 2016 17:38:26 +0000 (UTC) Subject: Re: svn commit: r301394 - head [If X_COMPILER_TYPE is defined, do not use it, otherwise use it?] DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 43E09203D1 To: Mark Millard , FreeBSD Current References: <23DACF49-E75D-4D49-BEB1-621500BC907A@dsl-only.net> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Sat, 4 Jun 2016 10:38:33 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <23DACF49-E75D-4D49-BEB1-621500BC907A@dsl-only.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WXp4voTb2LoiTSe57PCdhIbSH7E1DMetM" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jun 2016 17:38:29 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WXp4voTb2LoiTSe57PCdhIbSH7E1DMetM Content-Type: multipart/mixed; boundary="wfb4BhwW7tSAf7Dgo8U1W5cAuCQ8rRh4X" From: Bryan Drewery To: Mark Millard , FreeBSD Current Message-ID: Subject: Re: svn commit: r301394 - head [If X_COMPILER_TYPE is defined, do not use it, otherwise use it?] References: <23DACF49-E75D-4D49-BEB1-621500BC907A@dsl-only.net> In-Reply-To: <23DACF49-E75D-4D49-BEB1-621500BC907A@dsl-only.net> --wfb4BhwW7tSAf7Dgo8U1W5cAuCQ8rRh4X Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 6/4/2016 10:35 AM, Mark Millard wrote: > From the commit report: >=20 >> +.if defined(X_COMPILER_TYPE) >> CROSSENV+=3D COMPILER_VERSION=3D${COMPILER_VERSION} \ >> COMPILER_TYPE=3D${COMPILER_TYPE} \ >> COMPILER_FREEBSD_VERSION=3D${COMPILER_FREEBSD_VERSION} >=20 > This does not use X_COMPILER_TYPE when it is defined. >=20 >> +.else >> +CROSSENV+=3D COMPILER_VERSION=3D${X_COMPILER_VERSION} \ >> + COMPILER_TYPE=3D${X_COMPILER_TYPE} \ >> + COMPILER_FREEBSD_VERSION=3D${X_COMPILER_FREEBSD_VERSION} >=20 > This tries to use the undefined X_COMPILER_TYPE. >=20 >> +.endif >=20 >=20 >=20 > Overall: >=20 > A not seems to be missing or instead the nested code blocks need to be = swapped. >=20 I'm an idiot, thanks. --=20 Regards, Bryan Drewery --wfb4BhwW7tSAf7Dgo8U1W5cAuCQ8rRh4X-- --WXp4voTb2LoiTSe57PCdhIbSH7E1DMetM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXUxIZAAoJEDXXcbtuRpfP4N4H/2Ag9YZEOC3EBID3OQwd/cKT 3D5mJ07IGr1FZ0Ol90PUfYM+JS4iFgpMI56lQ3EwtHWMcss0JGzFhwlr/s51aVxg LZm8l2gebwXUoWx/DlrAEOryU+I5u12kGd37Felrugmm8zMMWzmF1TxJU1IKBt9F AyBVmqFjY9GqJ7DU62qa5nSDtPZiH0QNighkdyv5i1RxQ/n+4Uf+lw4fw0+1W5gG ymBQXOMXhHswk3JL1PIt35KzbAdLEq4Makcf2kpFXkAfKOizixHdhDtO6+Z0ZYwY WZ+NILEUpCHZpczv55P3cyjaJ6OziPua/kHKJnnzGzJRDlRV8jXKKjzfQJ8d6bA= =W+HW -----END PGP SIGNATURE----- --WXp4voTb2LoiTSe57PCdhIbSH7E1DMetM--