From owner-svn-ports-all@freebsd.org Tue Apr 11 15:25:06 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9704D39FAE; Tue, 11 Apr 2017 15:25:06 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: from mail-wr0-x22b.google.com (mail-wr0-x22b.google.com [IPv6:2a00:1450:400c:c0c::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4E5D219A; Tue, 11 Apr 2017 15:25:06 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: by mail-wr0-x22b.google.com with SMTP id z109so332933wrb.1; Tue, 11 Apr 2017 08:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=53QVbQ8vDgc/w9lTFXUyeP7GfzJsb/RQJ5JkDQQMghA=; b=M1hzV9B30QB/B7OuwCa+nPq5lcl82AN+Lf8+wYKvLKpQmwopdNgAhY19/qnl57CQHP ofsyk/P9t9rGDZ5spxaEjxjf1LB5Jdppf8wRZ9c9yFui8UC1da4+yra7oKAe0wpNXNkm uibdb9c+qcGIPnKqjqSW1sPFJoJ+iWhKICi3qU+pc8Mcut3yNQw433mTKPB+IM/Z+58T 4ajlgNvQS0JgdZiGNE3O0MQoScVGUDNEvbuWWre20OCVqACtVHJlIKi5WL+bBlIKGLuc vSKzrjyQT9KiKX0PgWtRU1zLcbW5I3TGX6xUH6QHp8hfjvJd4JUN1tY+uhIHp7zdyrzL un8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=53QVbQ8vDgc/w9lTFXUyeP7GfzJsb/RQJ5JkDQQMghA=; b=bqAhwODm/te+wgSshUM/faXFyFK6Klq6pzVBdTkO5XSpezyyGLn/0t3Hvc+UWG+vIE rEnWgxFUioyz+al3krg5rHz8fpg+0K4CSK8P5AKwBBBLfbdfciB4bAuOtAW2H+7b+MrD wxIA2T3/xReLVpJSPPZaoooDLXzPTDJNg/vTX65HJxyDpdNIaXvMtn6Hr0MHBE8PlKlm UFrV2FoM7cmIwDx1fPbw2fTHgtvB5XIvRJpka8HA6mtDxN1BX9EnmSc6p9XQ7Mpi0cXI 1VLPVmu1gF+fDdvVLL2lmfDcgLMsSjJUAghd/TEhLAfLNV4E1cwriiwKU/s/S1HXlguF Ox3g== X-Gm-Message-State: AN3rC/4tOc3aU7tkMliRnw3GwvnnpbSjDFuMOA/0ILochZoQiaH0VmNXDm9K+3G+gsifpga4x6Z+WgzIXVDR/g== X-Received: by 10.223.166.170 with SMTP id t39mr13553953wrc.72.1491924304568; Tue, 11 Apr 2017 08:25:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.171.91 with HTTP; Tue, 11 Apr 2017 08:25:04 -0700 (PDT) In-Reply-To: References: <201612260653.uBQ6rbp5054319@repo.freebsd.org> <20161226072913.0371FFAE@freefall.freebsd.org> From: Ben Woods Date: Tue, 11 Apr 2017 23:25:04 +0800 Message-ID: Subject: Re: svn commit: r429481 - in head: . x11 x11/lightdm x11/lightdm-gtk-greeter x11/lightdm/files To: Jan Beich Cc: Ben Woods , "ports-committers@FreeBSD.org" , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 15:25:06 -0000 Hi Jan, Apologies, I think I do remember seeing this, but the solution was not immediately obvious to me and I seem to have forgotten it. I have raised a PR to continue discussion and to ensure it doesn't get lost: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218564 I would be grateful if you could add text to that bug explaining the potential security implications, and elaborate on your proposed fix. Regards, Ben -- From: Benjamin Woods woodsb02@gmail.com On 9 April 2017 at 10:27, Jan Beich wrote: > jbeich@freebsd.org (Jan Beich) writes: > > >> --- /dev/null 00:00:00 1970 (empty, because file is newly > added) > >> +++ head/x11/lightdm/files/patch-src_process.c Mon Dec 26 > 06:53:37 2016 (r429481) > >> @@ -0,0 +1,11 @@ > >> +--- src/process.c.orig 2016-12-08 21:38:14 UTC > >> ++++ src/process.c > >> +@@ -231,7 +231,7 @@ process_start (Process *process, gboolea > >> + #ifdef HAVE_CLEARENV > >> + clearenv (); > >> + #else > >> +- environ = NULL; > >> ++ putenv ("environ=NULL"); > >> + #endif > >> + for (i = 0; i < env_length; i++) > >> + setenv (env_keys[i], env_values[i], TRUE); > > > > Looks bogus, see environ(7). Maybe use "env -i" version: > > > > extern char **environ; > > char *cleanenv[1]; > > environ = cleanenv; > > cleanenv[0] = NULL; > > Did you ignore this despite possible security implications? I'm not a user, > so just guessing. >