Date: Sat, 10 Jan 1998 20:12:36 -0800 (PST) From: Julian Elischer <julian@whistle.com> To: Brian Somers <brian@Awfulhak.org> Cc: "Jordan K. Hubbard" <jkh@time.cdrom.com>, Peter Wemm <peter@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-ports@FreeBSD.ORG Subject: Re: cvs commit: ports/www/squid12/patches patch-aj Message-ID: <Pine.BSF.3.95.980110201045.11339E-100000@current1.whistle.com> In-Reply-To: <199801102129.VAA19254@awfulhak.demon.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
YES, put it in.. we have 27 diffs between our code on 2.2.x and 3.0 24 of them are: #if ( __FreeBSD__ >= 3 ) #include <net/if_var.h> #endif this is a royal pain in the butt. julian On Sat, 10 Jan 1998, Brian Somers wrote: > > > #include <net/if_var.h>, only on FreeBSD >= 3. Brought to you by the > > > lets-make-life-as-difficult-as-possible-by-screwing-up-the-headers team. > > > > Thank you for making this point - it's been driving me nuts too. Talk > > about adding a lot of pain for a minescule gain! This is just > > whitespace removal flying under a different banner. :-( > > I forget who, but someone talked about removing this if_var.h > necessity a while ago. I believe it was originally only intended as > a kernel-specific file. > > It's *way* un-standard, and a real pain in the ass for ports. If you > don't build a new net/* port on both 2.2 & -current, you're almost > definitely gonna get hit by this. > > Can't we just #include it at the end of net/if.h and be done with it ? > Please ? Or does anyone want to fix it properly ? > > > Jordan > > -- > Brian <brian@Awfulhak.org>, <brian@FreeBSD.org>, <brian@OpenBSD.org> > <http://www.Awfulhak.org>; > Don't _EVER_ lose your sense of humour.... > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.95.980110201045.11339E-100000>