From owner-cvs-all@FreeBSD.ORG Fri Dec 26 07:45:45 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7593316A4CE; Fri, 26 Dec 2003 07:45:45 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B0BC43D46; Fri, 26 Dec 2003 07:45:44 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.10/8.12.9) with ESMTP id hBQFjfV9031377; Fri, 26 Dec 2003 07:45:41 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.10/8.12.10/Submit) id hBQFjfpM031376; Fri, 26 Dec 2003 07:45:41 -0800 (PST) (envelope-from obrien) Date: Fri, 26 Dec 2003 07:45:40 -0800 From: "David O'Brien" To: Doug Barton Message-ID: <20031226154540.GA31330@dragon.nuxi.com> References: <200312230234.hBN2YPZw040276@repoman.freebsd.org> <3FE9F86C.7060604@dougbarton.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3FE9F86C.7060604@dougbarton.net> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-BETA Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys _null.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Dec 2003 15:45:45 -0000 On Wed, Dec 24, 2003 at 12:34:52PM -0800, Doug Barton wrote: > >peter 2003/12/22 18:34:25 PST > > FreeBSD src repository > > Modified files: > > sys/sys _null.h > > Log: > > Don peril sensitive sunglasses and set NULL to an actual pointer type, > > but *only* for the kernel. We can do this because the kernel is not a > > standard C application environment. This would have stopped the recent > > mtx_* arg NULL/MTX_DEF mixups from going unnoticed for so long. > > Revision Changes Path > > 1.3 +4 -0 src/sys/sys/_null.h > > Is this worth a __FreeBSD_version bump? Nope. This isn't an ABI change. Both "0" and "(void *)0" are valid NULL definitions in ANSI-C. Peter's change only makes us code correctly, using "0" rather than "NULL" for int variables. Most likely using "NULL" with int variables is ANSI-C undefined behavior.