Date: Thu, 21 Jun 2007 21:42:05 -0400 (EDT) From: Thomas Abthorpe <thomas@goodking.ca> To: FreeBSD-gnats-submit@FreeBSD.org Cc: thomas@goodking.ca Subject: ports/113930: [MAINTAINER] shells/rssh: remove OSVERSION check for 4.X, pet portlint Message-ID: <200706220142.l5M1g53r014460@goodking.goodking.ca> Resent-Message-ID: <200706220150.l5M1o516058950@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 113930
>Category: ports
>Synopsis: [MAINTAINER] shells/rssh: remove OSVERSION check for 4.X, pet portlint
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Fri Jun 22 01:50:05 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator: Thomas Abthorpe
>Release: FreeBSD 6.2-RELEASE-p5 i386
>Organization:
GoodKing.Ca
>Environment:
System: FreeBSD goodking.goodking.ca 6.2-RELEASE-p5 FreeBSD 6.2-RELEASE-p5 #0: Sun Jun 10 14:58:15 EDT 2007
>Description:
- remove OSVERSION check for 4.X
- pet portlint, use DESTDIR for path to shells
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:
--- rssh-2.3.2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/shells/rssh/Makefile,v
retrieving revision 1.10
diff -u -r1.10 Makefile
--- Makefile 17 Jul 2006 20:03:19 -0000 1.10
+++ Makefile 22 Jun 2007 01:37:25 -0000
@@ -22,12 +22,6 @@
OPTIONS= RSYNC "rsync support" off \
RDIST "rdist support" off
-.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} < 500000
-IGNORE= wordexp() is not supported on 4.x
-.endif
-
.if defined(WITH_RSYNC)
RUN_DEPENDS+= ${LOCALBASE}/bin/rsync:${PORTSDIR}/net/rsync
CONFIGURE_ARGS+=--with-rsync=${LOCALBASE}/bin/rsync
@@ -43,10 +37,10 @@
${WRKSRC}/Makefile.in
post-install:
- @${ECHO_MSG} "updating /etc/shells"
- @${CP} /etc/shells /etc/shells.bak
- @(${GREP} -v ${PREFIX}/bin/${PORTNAME} /etc/shells.bak; \
- ${ECHO_CMD} ${PREFIX}/bin/${PORTNAME}) > /etc/shells
- @${RM} /etc/shells.bak
+ @${ECHO_MSG} "updating ${DESTDIR}/etc/shells"
+ @${CP} ${DESTDIR}/etc/shells ${DESTDIR}/etc/shells.bak
+ @(${GREP} -v ${PREFIX}/bin/${PORTNAME} ${DESTDIR}/etc/shells.bak; \
+ ${ECHO_CMD} ${PREFIX}/bin/${PORTNAME}) > ${DESTDIR}/etc/shells
+ @${RM} ${DESTDIR}/etc/shells.bak
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
--- rssh-2.3.2.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200706220142.l5M1g53r014460>