From owner-freebsd-rc@FreeBSD.ORG  Tue Jan  8 18:06:00 2013
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: rc@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id DC2A8A58
 for <rc@freebsd.org>; Tue,  8 Jan 2013 18:06:00 +0000 (UTC)
 (envelope-from smh@freebsd.org)
Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23])
 by mx1.freebsd.org (Postfix) with ESMTP id 7DA2F125
 for <rc@freebsd.org>; Tue,  8 Jan 2013 18:06:00 +0000 (UTC)
X-Spam-Processed: mail1.multiplay.co.uk, Tue, 08 Jan 2013 18:05:59 +0000
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
 mail1.multiplay.co.uk
X-Spam-Level: 
X-Spam-Status: No, score=-5.0 required=6.0 tests=USER_IN_WHITELIST
 shortcircuit=ham autolearn=disabled version=3.2.5
Received: from r2d2 ([188.220.16.49])
 by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23])
 (MDaemon PRO v10.0.4) with ESMTP id md50001617563.msg
 for <rc@freebsd.org>; Tue, 08 Jan 2013 18:05:58 +0000
X-MDRemoteIP: 188.220.16.49
X-Return-Path: smh@freebsd.org
X-Envelope-From: smh@freebsd.org
X-MDaemon-Deliver-To: rc@freebsd.org
Message-ID: <34B5ED8BFFD24CACB5A7E92BC29D2AA6@multiplay.co.uk>
From: "Steven Hartland" <smh@freebsd.org>
To: <rc@freebsd.org>
Subject: Fix rc.subr dealing with some daemons
Date: Tue, 8 Jan 2013 18:06:11 -0000
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
 reply-type=original
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.5931
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
 <freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2013 18:06:00 -0000

I'm looking to commit the patch I suggested back in 2007
in PR, if there no objections?
http://www.freebsd.org/cgi/query-pr.cgi?pr=117027

In summary it adds and additional valid pattern, which
while could in a very rare case increase false positive
test, no more so than any of the patterns which IMO
is better than the current state which means these
daemons always fail.

--- /etc/rc.subr.orig    Mon Oct  8 18:31:34 2007+++ /etc/rc.subr       Mon Oct  8 18:32:31 2007@@ -271,5 +271,5 @@
           _fp_args='_argv'
               _fp_match='case "$_argv" in
-                 ${_interp}|"${_interp} "*|"${_interpbn}: ${_procname}"*)'
+                 ${_interp}|"${_interp} "*|"[${_interpbn}]"|"${_interpbn}: ${_procname}"*)'
       else                                    # a normal daemon
              _procnamebn=${_procname##*/}

    Regards
    Steve