From owner-cvs-all  Fri Mar 23 13:17:50 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailout04.sul.t-online.com (mailout04.sul.t-online.com [194.25.134.18])
	by hub.freebsd.org (Postfix) with ESMTP
	id D15D937B719; Fri, 23 Mar 2001 13:17:40 -0800 (PST)
	(envelope-from garyj@peedub.muc.de)
Received: from fwd03.sul.t-online.com 
	by mailout04.sul.t-online.com with smtp 
	id 14gYwF-0002kj-03; Fri, 23 Mar 2001 22:17:39 +0100
Received: from peedub.muc.de (320038014727-0001@[217.80.40.49]) by fmrl03.sul.t-online.com
	with esmtp id 14gYw2-1fBBmSC; Fri, 23 Mar 2001 22:17:26 +0100
Received: by peedub.muc.de (8.11.3/8.11.1) id f2NLHKA08153;
	Fri, 23 Mar 2001 22:17:20 +0100 (CET)
	(envelope-from garyj)
Content-Type: text/plain;
  charset="iso-8859-1"
From: Gary Jennejohn <garyj@jennejohn.org>
Reply-To: garyj@jennejohn.org
To: Joerg Wunsch <joerg@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if_spppsubr.c
Date: Fri, 23 Mar 2001 22:17:13 +0100
X-Mailer: KMail [version 1.2]
References: <200103231951.f2NJpDA18258@freefall.freebsd.org>
In-Reply-To: <200103231951.f2NJpDA18258@freefall.freebsd.org>
MIME-Version: 1.0
Message-Id: <01032322171301.23095@peedub.muc.de>
Content-Transfer-Encoding: 8bit
X-Sender: 320038014727-0001@t-dialin.net
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Friday 23 March 2001 20:51, Joerg Wunsch wrote:
> joerg       2001/03/23 11:51:13 PST
>
>   Modified files:
>     sys/net              if_spppsubr.c
>   Log:
>   (MFC candidate, see below).
>
>   When we get an Open event in stopped state, experience shows that this
>   is usually means we've somehow missed a previous Down event.  This has
>   occasionally bitten people for the IPCP layer with ISDN, apparently a
>   previously aborted IPCP negotiation must have caused this.  As a
>   bandaid, we quickly pretent a Down event by advancing to starting
>   state; this effectively implements the `restart' option mentioned in
>   RFC 1663.
>
>   While i'm not yet fully convinced this is the best thing to do (and is
>   fully compliant with RFC 1661), i've seen a number of reports here on
>   the German mailing lists where people have been bitten by the previous
>   behaviour which usually causes quickly looping ISDN reconnects (thus
>   loss of money...), and where just this patch fixes the problem.
>
>   For this, i'd even like to see it MFC'd if possible.
>
>   Submitted by:	Helmut Kreft <kreft@zeus.ai-lab.fh-furtwangen.de>
>
>   Revision  Changes    Path
>   1.65      +15 -1     src/sys/net/if_spppsubr.c

i4b doesn't use this anymore, it has its own private copy in 
/sys/i4b/driver/i4b_ispppsubr.c., at least in -CURRENT. Maybe this change 
should be applied there too ? I'm not suer what the situation is in -STABLE.

-- 
Gary Jennejohn garyj@jennejohn.org gj@freebsd.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message