From owner-freebsd-java@FreeBSD.ORG Tue Dec 9 03:31:14 2008 Return-Path: Delivered-To: java@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D4231065670; Tue, 9 Dec 2008 03:31:14 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16]) by mx1.freebsd.org (Postfix) with ESMTP id E48F78FC08; Tue, 9 Dec 2008 03:31:13 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.14.2/8.14.2) with ESMTP id mB93CE2D043314; Mon, 8 Dec 2008 19:12:14 -0800 (PST) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.14.2/8.14.2/Submit) id mB93CEOV043313; Mon, 8 Dec 2008 19:12:14 -0800 (PST) (envelope-from glewis@eyesbeyond.com) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Mon, 8 Dec 2008 19:12:14 -0800 From: Greg Lewis To: Joe Marcus Clarke Message-ID: <20081209031214.GA33028@misty.eyesbeyond.com> References: <1228667884.69753.20.camel@shumai.marcuscom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1228667884.69753.20.camel@shumai.marcuscom.com> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: java@FreeBSD.org Subject: Re: [Fwd: portlint and USE_ANT] X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Dec 2008 03:31:14 -0000 On Sun, Dec 07, 2008 at 11:38:04AM -0500, Joe Marcus Clarke wrote: > I received this email from a user. Is this the correct change to make > to portlint? I didn't see an attached change, but it looks like the FATAL should be turned into a WARNING. So if thats what you meant then I would agree. Certainly defining do-build when you have set USE_ANT is normally a bug, so portlint should continue to do something in that situation, but a FATAL looks to be too restrictive. I took a look at the port in question and the usage looked fine to me. Content-Description: Forwarded message - portlint and USE_ANT > Delivered-To: marcus@freebsd.org > Date: Mon, 01 Dec 2008 10:07:49 +0100 > From: Dominic Fandrey > User-Agent: Thunderbird 2.0.0.18 (X11/20081123) > To: marcus@FreeBSD.org > Subject: portlint and USE_ANT > X-Enigmail-Version: 0.95.7 > X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham > version=3.2.5 > X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on > creme-brulee.marcuscom.com > > Portlint issues a FATAL message about USE_ANT for a port of mine: > > # cd /usr/ports/java/phpeclipse > # portlint ./ > FATAL: Makefile: USE_ANT is intended only for ports that build with Ant. You should not override ``do-build'' when defining USE_ANT > 1 fatal error and 0 warnings found. > > In my opinion my use of USE_ANT is correct, though. This is from > bsd.java.mk: > > > USE_ANT > > Should be defined when the port uses Apache Ant. Ant is thus > > considered to be the sub-make command. When no 'do-build' > > target is defined by the port, a default one will be set > > that simply runs Ant according to MAKE_ENV, MAKE_ARGS and > > ALL_TARGET. Read the documentation in bsd.port.mk for more > > information. > > This explicitly states the possibility of defining your own > do-build target. > > The FATAL error keeps me from running 'port test'. > > Regards, > Dominic > -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org