From owner-freebsd-acpi@FreeBSD.ORG Fri May 28 10:33:48 2004 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A66216A4CE for ; Fri, 28 May 2004 10:33:48 -0700 (PDT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4BF3043D2D for ; Fri, 28 May 2004 10:33:48 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 2479 invoked from network); 28 May 2004 17:33:29 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 28 May 2004 17:33:29 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i4SHXOVo029475; Fri, 28 May 2004 13:33:26 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: freebsd-acpi@FreeBSD.org Date: Fri, 28 May 2004 13:34:03 -0400 User-Agent: KMail/1.6 References: <29AC424F54821A4FB5D7CBE081922E40928BB1@hdsmsx403.hd.intel.com> <200405281236.52812.jhb@FreeBSD.org> <20040528095533.E99072@root.org> In-Reply-To: <20040528095533.E99072@root.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200405281334.03956.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: acpi@FreeBSD.org Subject: Re: Bug? PCI link device _SRS X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 May 2004 17:33:48 -0000 On Friday 28 May 2004 01:00 pm, Nate Lawson wrote: > John, great to see you're working on a lot of these already. Appreciate > it. > > On Fri, 28 May 2004, John Baldwin wrote: > > On Thursday 27 May 2004 04:55 pm, Brown, Len wrote: > > > If a platform gives you a _CRS IRQ that > > > is outside the _PRS list, then do no > > > stick with the _CRS -- select > > > a new (valid) one from the _PRS list. > > > > Ah, I have a patch to do this already that I can commit. > > > > > If a platform gives you a _CRS IRQ that > > > is different from the _SRS you just > > > invoked. Assume that the _SRS worked > > > and that the _CRS is bogus. > > > > Huh, we don't do that type of checking, but we do use _CRS for later > > devices routed to the same link to see what IRQ they should use. > > I think the first one will take care of how we handle this one. We'll do > _SRS and ignore the _CRS that comes back. Later, we go to program a > device that has the same link and its _CRS will be outside the _PRS list, > so we'll fall back to selecting a valid one from _PRS. But what if we chose a different IRQ? Then the routing for the earlier device would be wrong. acpi_pcib_route_interrupt() needs to work with the pci_link code more closely, and we should cache the current IRQ in the softc and use that to determine if it is routed rather than _CRS I think. This is how the new $PIR code works. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org