Date: Thu, 17 Jul 2008 03:21:02 -0700 From: Luoqi Chen <Luoqi.Chen@brion.com> To: "freebsd-usb@freebsd.org" <freebsd-usb@freebsd.org> Subject: Maintainer of usb code Message-ID: <0707E37B6D2E244C85660487B602C92217ABC04434@ex02.briontech.com>
next in thread | raw e-mail | index | archive | help
Hello,
Do we have an official maintainer of the usb code? I came across some quite=
trivial
errors while debugging another problem (which turned out not to be usb rela=
ted),
please see the diff below. I'm not terribly familiar with the usb code, so =
I'd like
to seek someone to review this change,
Index: ohci.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/src/sys/dev/usb/ohci.c,v
retrieving revision 1.170
diff -u -r1.170 ohci.c
--- ohci.c 20 Jun 2007 05:10:52 -0000 1.170
+++ ohci.c 17 Jul 2008 10:07:07 -0000
@@ -815,20 +815,19 @@
ohci_controller_init(ohci_softc_t *sc)
{
int i;
- u_int32_t s, ctl, ival, hcr, fm, per, desca;
+ u_int32_t ctl, ival, hcr, fm, per, desca;
/* Determine in what context we are running. */
ctl =3D OREAD4(sc, OHCI_CONTROL);
if (ctl & OHCI_IR) {
/* SMM active, request change */
DPRINTF(("ohci_init: SMM active, request owner change\n"));
- s =3D OREAD4(sc, OHCI_COMMAND_STATUS);
- OWRITE4(sc, OHCI_COMMAND_STATUS, s | OHCI_OCR);
+ OWRITE4(sc, OHCI_COMMAND_STATUS, OHCI_OCR);
for (i =3D 0; i < 100 && (ctl & OHCI_IR); i++) {
usb_delay_ms(&sc->sc_bus, 1);
ctl =3D OREAD4(sc, OHCI_CONTROL);
}
- if ((ctl & OHCI_IR) =3D=3D 0) {
+ if (ctl & OHCI_IR) {
printf("%s: SMM does not respond, resetting\n",
device_get_nameunit(sc->sc_bus.bdev));
OWRITE4(sc, OHCI_CONTROL, OHCI_HCFS_RESET);
Thanks
-lq
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0707E37B6D2E244C85660487B602C92217ABC04434>